'Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2016-07-21 22:51:22
Message-ID: 20160721225122.32703.80399 () mimi ! kde ! org
[Download RAW message or body]

--===============6995475955320988943==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128490/#review97737
-----------------------------------------------------------

Just a tiny note - that separator is horizontal, not vertical ;)

- Martin Klapetek

On July 20, 2016, 3:01 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128490/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 3:01 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Follow up of RR [128283](https://git.reviewboard.kde.org/r/128283/) and in \
> particular [128466](https://git.reviewboard.kde.org/r/128466/). This patch replaces \
> the "Share" groupbox with a vertical separator. 
> Don't forget that there is also RR \
> [128413](https://git.reviewboard.kde.org/r/128413/) pending ;) 
> 
> Diffs
> -----
> 
> src/widgets/checksumswidget.ui 03c64db 
> src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128490/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png
>  After
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png
>  
> 
> Thanks,
> 
> Elvis Angelaccio
> 
> 

--===============6995475955320988943==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128490/">https://git.reviewboard.kde.org/r/128490/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
a tiny note - that separator is horizontal, not vertical ;)</p></pre>  <br />

<p>- Martin Klapetek</p>

<br />
<p>On July 20th, 2016, 3:01 p.m. CEST, Elvis Angelaccio wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and KDE Usability.</div>
<div>By Elvis Angelaccio.</div>

<p style="color: grey;"><i>Updated July 20, 2016, 3:01 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Follow up of RR <a \
href="https://git.reviewboard.kde.org/r/128283/" style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">128283</a> and in \
particular <a href="https://git.reviewboard.kde.org/r/128466/" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">128466</a>. This patch replaces the "Share" groupbox with a vertical \
separator.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't forget that there is also RR <a \
href="https://git.reviewboard.kde.org/r/128413/" style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">128413</a> pending \
;)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/widgets/checksumswidget.ui <span style="color: grey">(03c64db)</span></li>

 <li>src/widgets/kpropertiesdialog.cpp <span style="color: \
grey">(808765c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128490/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png">Before</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png">After</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6995475955320988943==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 