[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-07-21 21:31:11
Message-ID: 20160721213111.4909.62792 () mimi ! kde ! org
[Download RAW message or body]
--===============4138830415606725908==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128451/#review97731
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On July 21, 2016, 3:30 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128451/
> -----------------------------------------------------------
>
> (Updated July 21, 2016, 3:30 p.m.)
>
>
> Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and Jeremy Whiting.
>
>
> Repository: kio
>
>
> Description
> -------
>
> KNameAndUrlInputDialog::url() makes URLs absolute (which is useful in
> general, for e.g. passing to KIO), so I added urlText() to retrieve
> the text as is.
>
> This removes all the code about showing an error on remote URLs; we just
> create symlinks to the requested target, whether it looks like "../foo" or
> "a:/b" which could be a relative path too (although an unusual one).
>
> Bug misreported as a comment in bug 352927.
>
>
> Diffs
> -----
>
> src/filewidgets/knameandurlinputdialog.h c32745d02a1a7361ac35a836cf57d7b9952cc49f
> src/filewidgets/knameandurlinputdialog.cpp b7a6645874673e998e05ee73a2daef746ce39dd6 \
> src/filewidgets/knewfilemenu.cpp 2e613b19a98587c9a62c9cccf0f8695730798e89
>
> Diff: https://git.reviewboard.kde.org/r/128451/diff/
>
>
> Testing
> -------
>
> Created a symlink to "../anotherdir" in konqueror/dolphinpart using "Create New" / \
> "Basic link to file or directory...", the target now stays relative.
> I looked up who wrote that symlink creation code in order to add him as a reviewer \
> .... turns out the author of commit 8684162 in kde-baseapps is .... me.
>
> Thanks,
>
> David Faure
>
>
--===============4138830415606725908==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128451/">https://git.reviewboard.kde.org/r/128451/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On July 21st, 2016, 3:30 p.m. MDT, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and Jeremy \
Whiting.</div> <div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 21, 2016, 3:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KNameAndUrlInputDialog::url() makes URLs absolute (which is useful in \
general, for e.g. passing to KIO), so I added urlText() to retrieve the text as is.
This removes all the code about showing an error on remote URLs; we just
create symlinks to the requested target, whether it looks like "../foo" or
"a:/b" which could be a relative path too (although an unusual one).
Bug misreported as a comment in bug 352927.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Created a symlink to "../anotherdir" in \
konqueror/dolphinpart using "Create New" / "Basic link to file or directory...", the \
target now stays relative.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I looked up who wrote that symlink \
creation code in order to add him as a reviewer .... turns out the author of commit \
8684162 in kde-baseapps is .... me.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/filewidgets/knameandurlinputdialog.h <span style="color: \
grey">(c32745d02a1a7361ac35a836cf57d7b9952cc49f)</span></li>
<li>src/filewidgets/knameandurlinputdialog.cpp <span style="color: \
grey">(b7a6645874673e998e05ee73a2daef746ce39dd6)</span></li>
<li>src/filewidgets/knewfilemenu.cpp <span style="color: \
grey">(2e613b19a98587c9a62c9cccf0f8695730798e89)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128451/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4138830415606725908==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic