[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-07-21 21:22:49
Message-ID: 20160721212249.4909.88534 () mimi ! kde ! org
[Download RAW message or body]
--===============7675512139067303321==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128494/#review97728
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On July 21, 2016, 3:06 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128494/
> -----------------------------------------------------------
>
> (Updated July 21, 2016, 3:06 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> slotCancel() isn't called when pressing Esc or closing the window with
> the window manager button.
>
> Doing this the more standard way (reimplementing accept() and reject())
> simplifies the code (since KPageDialog sets up the buttonbox this way already)
> and will be useful for knewfilemenutest which calls accept() on all types of \
> dialog.
>
> Diffs
> -----
>
> src/widgets/kpropertiesdialog.h b451a6ffcb248beb324ef612a0336148c96bccc2
> src/widgets/kpropertiesdialog.cpp 808765c706ded7f109719bb2d731692fca0163d8
> tests/kpropertiesdialogtest.cpp 7b180608716fa7de0bb2e5221330d0be958ef945
>
> Diff: https://git.reviewboard.kde.org/r/128494/diff/
>
>
> Testing
> -------
>
> Looking at the output from kpropertiesdialogtest, to ensure the signals are \
> emitted, and only once. Tested OK, Cancel, Esc, Alt+F4.
>
>
> Thanks,
>
> David Faure
>
>
--===============7675512139067303321==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128494/">https://git.reviewboard.kde.org/r/128494/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On July 21st, 2016, 3:06 p.m. MDT, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 21, 2016, 3:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">slotCancel() isn't called when pressing Esc or closing the window \
with the window manager button.
Doing this the more standard way (reimplementing accept() and reject())
simplifies the code (since KPageDialog sets up the buttonbox this way already)
and will be useful for knewfilemenutest which calls accept() on all types of \
dialog.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looking at the output from kpropertiesdialogtest, to \
ensure the signals are emitted, and only once. Tested OK, Cancel, Esc, \
Alt+F4.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kpropertiesdialog.h <span style="color: \
grey">(b451a6ffcb248beb324ef612a0336148c96bccc2)</span></li>
<li>src/widgets/kpropertiesdialog.cpp <span style="color: \
grey">(808765c706ded7f109719bb2d731692fca0163d8)</span></li>
<li>tests/kpropertiesdialogtest.cpp <span style="color: \
grey">(7b180608716fa7de0bb2e5221330d0be958ef945)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128494/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7675512139067303321==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic