[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-07-11 20:19:23
Message-ID: 20160711201923.603.56251 () mimi ! kde ! org
[Download RAW message or body]
--===============8170410305564803190==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128397/#review97294
-----------------------------------------------------------
Is this same as https://bugs.kde.org/show_bug.cgi?id=365355
- Anthony Fieroni
On July 8, 2016, 3:24 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128397/
> -----------------------------------------------------------
>
> (Updated July 8, 2016, 3:24 p.m.)
>
>
> Review request for KDE Frameworks and Olivier Goffart.
>
>
> Bugs: 365130
> https://bugs.kde.org/show_bug.cgi?id=365130
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> QIcon::hasThemeIcon(name) checks if QIcon::name() == name, so icon engine must \
> return empty string when icon doesn't exist. Also implement IsNullHook for Qt 5.7. \
> Comes with autotest.
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 0c7de50
> autotests/kiconengine_unittest.cpp PRE-CREATION
> src/kiconengine.h 21a63f5
> src/kiconengine.cpp 3ccc7d1
>
> Diff: https://git.reviewboard.kde.org/r/128397/diff/
>
>
> Testing
> -------
>
> Issue was reported in https://bugreports.qt.io/browse/QTBUG-54595
> Also similar issue https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check \
> for hasThemeIcon before using the icon, but it returns true which results in \
> invalid icon name -> no icon).
>
> Thanks,
>
> David Rosca
>
>
--===============8170410305564803190==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128397/">https://git.reviewboard.kde.org/r/128397/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
this same as https://bugs.kde.org/show_bug.cgi?id=365355</p></pre> <br />
<p>- Anthony Fieroni</p>
<br />
<p>On July 8th, 2016, 3:24 p.m. EEST, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Olivier Goffart.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated July 8, 2016, 3:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=365130">365130</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QIcon::hasThemeIcon(name) checks if QIcon::name() == \
name, so icon engine must return empty string when icon doesn't exist. Also implement \
IsNullHook for Qt 5.7. Comes with autotest.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Issue was reported in \
https://bugreports.qt.io/browse/QTBUG-54595 Also similar issue \
https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check for hasThemeIcon before \
using the icon, but it returns true which results in invalid icon name -> no \
icon).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(0c7de50)</span></li>
<li>autotests/kiconengine_unittest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kiconengine.h <span style="color: grey">(21a63f5)</span></li>
<li>src/kiconengine.cpp <span style="color: grey">(3ccc7d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128397/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8170410305564803190==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic