From kde-frameworks-devel Sun Jul 10 07:44:49 2016 From: Michel Hermier Date: Sun, 10 Jul 2016 07:44:49 +0000 To: kde-frameworks-devel Subject: Re: Review Request 128413: Add clipboard buttons in the Checksums tab Message-Id: <20160710074449.8816.91580 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=146813672629233 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4028331294118774267==" --===============4028331294118774267== Content-Type: multipart/alternative; boundary="===============1179189961256324748==" --===============1179189961256324748== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97249 ----------------------------------------------------------- I don't see the point of this change. From a user perspective a user knowing what a hash is know how to use context menu to reach this panel and should be educated enought to know the copy/paste shortcuts. For me it is more interesting that when cliking on text it would select the whole hash text. - Michel Hermier On juil. 9, 2016, 7:55 après-midi, Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128413/ > ----------------------------------------------------------- > > (Updated juil. 9, 2016, 7:55 après-midi) > > > Review request for KDE Frameworks, KDE Usability and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed in RR 128283, we can improve the usability of the dialog if we add buttons to interact with the clipboard. > > The Paste button is always visible, while the three Copy buttons are hidden until the correspoding checksum is computed. > > > Diffs > ----- > > src/widgets/checksumswidget.ui 03c64db > src/widgets/kpropertiesdialog.cpp 808765c > > Diff: https://git.reviewboard.kde.org/r/128413/diff/ > > > Testing > ------- > > Copy/Paste works as expected. > > > File Attachments > ---------------- > > Paste button next to the input field. > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png > Example of Copy button > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png > > > Thanks, > > Elvis Angelaccio > > --===============1179189961256324748== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/ 

I don't see the point of this change. From a user perspective a user knowing what a hash is know how to use context menu to reach this panel and should be educated enought to know the copy/paste shortcuts.
For me it is more interesting that when cliking on text it would select the whole hash text.

- Michel Hermier


On juillet 9th, 2016, 7:55 après-midi UTC, Elvis Angelaccio wrote:

Review request for KDE Frameworks, KDE Usability and David Faure.
By Elvis Angelaccio.

Updated juil. 9, 2016, 7:55 après-midi

Repository: kio

Description 

As discussed in RR 128283, we can improve the usability of the dialog if we add buttons to interact with the clipboard.


The Paste button is always visible, while the three Copy buttons are hidden until the correspoding checksum is computed.

Testing 

Copy/Paste works as expected.

Diffs

  • src/widgets/checksumswidget.ui (03c64db)
  • src/widgets/kpropertiesdialog.cpp (808765c)

View Diff

File Attachments

  • Paste button next to the input field.
  • Example of Copy button
    		•
    --===============1179189961256324748==-- --===============4028331294118774267== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============4028331294118774267==--