[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true
From: Olivier Goffart <ogoffart () kde ! org>
Date: 2016-07-08 8:59:05
Message-ID: 20160708085905.2360.54938 () mimi ! kde ! org
[Download RAW message or body]
--===============1108594164342934963==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128397/#review97193
-----------------------------------------------------------
src/kiconengine.cpp (line 164)
<https://git.reviewboard.kde.org/r/128397/#comment65647>
Ideally, one would want that even if compiled with older Qt, this works as Qt is \
upgraded.
The way to do that would be to hardcode the numerical value of \
QIconEngine::IsNullHook when compiling with older Qt.
- Olivier Goffart
On July 7, 2016, 9:55 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128397/
> -----------------------------------------------------------
>
> (Updated July 7, 2016, 9:55 p.m.)
>
>
> Review request for KDE Frameworks and Olivier Goffart.
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> QIcon::hasThemeIcon(name) checks if QIcon::name() == name, so icon engine must \
> return empty string when icon doesn't exist. Also implement IsNullHook for Qt 5.7. \
> Comes with autotest.
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 0c7de50
> autotests/kiconengine_unittest.cpp PRE-CREATION
> src/kiconengine.h 21a63f5
> src/kiconengine.cpp 3ccc7d1
>
> Diff: https://git.reviewboard.kde.org/r/128397/diff/
>
>
> Testing
> -------
>
> Issue was reported in https://bugreports.qt.io/browse/QTBUG-54595
> Also similar issue https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check \
> for hasThemeIcon before using the icon, but it returns true which results in \
> invalid icon name -> no icon).
>
> Thanks,
>
> David Rosca
>
>
--===============1108594164342934963==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128397/">https://git.reviewboard.kde.org/r/128397/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128397/diff/1/?file=471283#file471283line164" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kiconengine.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">164</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#if QT_VERSION >= QT_VERSION_CHECK(5, 7, 0)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Ideally, one would want that even if compiled with older Qt, this works as \
Qt is upgraded.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The way to do that would be to hardcode \
the numerical value of QIconEngine::IsNullHook when compiling with older \
Qt.</p></pre> </div>
</div>
<br />
<p>- Olivier Goffart</p>
<br />
<p>On July 7th, 2016, 9:55 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Olivier Goffart.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated July 7, 2016, 9:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QIcon::hasThemeIcon(name) checks if QIcon::name() == \
name, so icon engine must return empty string when icon doesn't exist. Also implement \
IsNullHook for Qt 5.7. Comes with autotest.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Issue was reported in \
https://bugreports.qt.io/browse/QTBUG-54595 Also similar issue \
https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check for hasThemeIcon before \
using the icon, but it returns true which results in invalid icon name -> no \
icon).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(0c7de50)</span></li>
<li>autotests/kiconengine_unittest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kiconengine.h <span style="color: grey">(21a63f5)</span></li>
<li>src/kiconengine.cpp <span style="color: grey">(3ccc7d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128397/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1108594164342934963==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic