'Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-07-07 21:25:58
Message-ID: 20160707212558.2360.48402 () mimi ! kde ! org
[Download RAW message or body]

--===============4465053689059865649==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128397/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kiconthemes

Description
-------

QIcon::hasThemeIcon(name) checks if QIcon::name() == name, so icon engine must return \
empty string when icon doesn't exist. Also implement IsNullHook for Qt 5.7. Comes \
with autotest.

Diffs
-----

  autotests/CMakeLists.txt 0c7de50 
  autotests/kiconengine_unittest.cpp PRE-CREATION 
  src/kiconengine.h 21a63f5 
  src/kiconengine.cpp 3ccc7d1 

Diff: https://git.reviewboard.kde.org/r/128397/diff/

Testing
-------

Issue was reported in https://bugreports.qt.io/browse/QTBUG-54595
Also similar issue https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check for \
hasThemeIcon before using the icon, but it returns true which results in invalid icon \
name -> no icon).

Thanks,

David Rosca

--===============4465053689059865649==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128397/">https://git.reviewboard.kde.org/r/128397/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Rosca.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QIcon::hasThemeIcon(name) checks if QIcon::name() == \
name, so icon engine must return empty string when icon doesn't exist. Also implement \
IsNullHook for Qt 5.7. Comes with autotest.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Issue was reported in \
https://bugreports.qt.io/browse/QTBUG-54595 Also similar issue \
https://bugs.kde.org/show_bug.cgi?id=365031 (there is a check for hasThemeIcon before \
using the icon, but it returns true which results in invalid icon name -&gt; no \
icon).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(0c7de50)</span></li>

 <li>autotests/kiconengine_unittest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kiconengine.h <span style="color: grey">(21a63f5)</span></li>

 <li>src/kiconengine.cpp <span style="color: grey">(3ccc7d1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128397/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4465053689059865649==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 