'Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just
From:       Jeremy Whiting <jpwhiting () kde ! org>
Date:       2016-06-29 14:23:51
Message-ID: 20160629142351.5107.13734 () mimi ! kde ! org
[Download RAW message or body]

--===============3384240890575508691==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128317/#review96956
-----------------------------------------------------------

Ship it!

Ship It!

- Jeremy Whiting

On June 29, 2016, 5:27 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128317/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 5:27 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> the recent change ed0a1be18ec5b421fc1319d2a28f118d9ea324b9 made the download dialog \
> fail if a category is not found. 
> this fixes the dialog showing completely unrelated stuff, but it's too much.
> if even just one category is available, the safest way is to show whatever of the \
> available categories was found. the new server will have some category less (for \
> instance most of the categories like "KDE Wallpaper 800x600" will go, so in order \
> to be compatible with old clients, it needs to show content even if one of the \
> categories are available) 
> 
> Diffs
> -----
> 
> src/attica/atticaprovider.cpp ad506cd 
> 
> Diff: https://git.reviewboard.kde.org/r/128317/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============3384240890575508691==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128317/">https://git.reviewboard.kde.org/r/128317/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Jeremy Whiting</p>

<br />
<p>On June 29th, 2016, 5:27 a.m. MDT, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated June 29, 2016, 5:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the recent change \
ed0a1be18ec5b421fc1319d2a28f118d9ea324b9 made the download dialog fail if a category \
is not found.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this fixes the dialog showing completely unrelated \
stuff, but it's too much. if even just one category is available, the safest way is \
to show whatever of the available categories was found. the new server will have some \
category less (for instance most of the categories like "KDE Wallpaper 800x600" will \
go, so in order to be compatible with old clients, it needs to show content even if \
one of the categories are available)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/attica/atticaprovider.cpp <span style="color: grey">(ad506cd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128317/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3384240890575508691==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 