'Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2016-06-16 16:02:11
Message-ID: 20160616160211.9803.68995 () mimi ! kde ! org
[Download RAW message or body]

--===============6095086719762625384==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128187/
-----------------------------------------------------------

(Updated June 16, 2016, 4:02 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Andreas Kainz, David Faure, and Kevin Funk.

Repository: breeze-icons

Description
-------

On windows git converts symbolic links to text files with links to
the actual file. This added application modifies the .qrc to use
aliases for the links.

This change also adds an option to not install the icons.

Diffs
-----

  CMakeLists.txt 08cd1a0 
  icons-dark/CMakeLists.txt 5d7e6f8 
  icons/CMakeLists.txt bd4c048 
  qrcAlias.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128187/diff/

Testing
-------

Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled.

We get the icon .rcc file and the icons where not installed

Thanks,

Kåre Särs

--===============6095086719762625384==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128187/">https://git.reviewboard.kde.org/r/128187/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Andreas Kainz, David Faure, and Kevin \
Funk.</div> <div>By Kåre Särs.</div>

<p style="color: grey;"><i>Updated June 16, 2016, 4:02 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-icons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On windows git converts symbolic links to text files with links to the \
actual file. This added application modifies the .qrc to use aliases for the links.

This change also adds an option to not install the icons.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS \
enabled.

We get the icon .rcc file and the icons where not installed</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(08cd1a0)</span></li>

 <li>icons-dark/CMakeLists.txt <span style="color: grey">(5d7e6f8)</span></li>

 <li>icons/CMakeLists.txt <span style="color: grey">(bd4c048)</span></li>

 <li>qrcAlias.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128187/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6095086719762625384==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 