'Re: Review Request 128083: Find CPUs by subsystem rather than driver'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128083: Find CPUs by subsystem rather than driver
From:       Rohan Garg <rohangarg () kubuntu ! org>
Date:       2016-06-07 11:46:47
Message-ID: 20160607114647.3239.90617 () mimi ! kde ! org
[Download RAW message or body]

--===============3073064946115710041==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On June 7, 2016, 3:03 a.m., Rohan Garg wrote:
> > Hi
> > Could we get a shipit on these? I'd really appreciate it if we could have these \
> > in Frameworks 5.23
> 
> Martin Gräßlin wrote:
> I don't want to disappoint you, but it's too late for 5.23
> 
> Kai Uwe Broulik wrote:
> If you give dfaure a cookie I'm sure he would re-spin for you. Tagging is on the \
> first Saturday, release on the *second*.

I'm sure that can be arranged ;)

- Rohan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/#review96236
-----------------------------------------------------------

On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128083/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> The driver "processor" is part of the ACPI module, which isn't used by
> all systems and architectures.
> 
> Detecting devices by CPU subsystem seems to work, and whilst
> theoretically this change could pick up a non CPU device in the same subsystem they
> would be filtered out by the udevmanager which has an extra check
> that CPUs are valid and not just empty sockets.
> 
> 
> Diffs
> -----
> 
> src/solid/devices/backends/udev/udevdevice.cpp \
> 9fb5e092679cd3c6860b2055cf3dedb915addfda  \
> src/solid/devices/backends/udev/udevmanager.cpp \
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc  
> Diff: https://git.reviewboard.kde.org/r/128083/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============3073064946115710041==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128083/">https://git.reviewboard.kde.org/r/128083/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 7th, 2016, 3:03 a.m. IST, <b>Rohan \
Garg</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi Could we get a shipit on these? I'd really \
appreciate it if we could have these in Frameworks 5.23</p></pre>  </blockquote>

 <p>On June 7th, 2016, 1:17 p.m. IST, <b>Martin Gräßlin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't want to disappoint you, but it's too late for 5.23</p></pre>  </blockquote>

 <p>On June 7th, 2016, 2:50 p.m. IST, <b>Kai Uwe Broulik</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you give dfaure a cookie I'm sure he would re-spin for you. Tagging is on the first \
Saturday, release on the <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">second</em>.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
sure that can be arranged ;)</p></pre> <br />

<p>- Rohan</p>

<br />
<p>On June 3rd, 2016, 5:45 p.m. IST, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Solid.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated June 3, 2016, 5:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The driver "processor" is part of the ACPI module, \
which isn't used by all systems and architectures.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Detecting devices by CPU subsystem seems to work, and \
whilst theoretically this change could pick up a non CPU device in the same subsystem \
they would be filtered out by the udevmanager which has an extra check
that CPUs are valid and not just empty sockets.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/solid/devices/backends/udev/udevdevice.cpp <span style="color: \
grey">(9fb5e092679cd3c6860b2055cf3dedb915addfda)</span></li>

 <li>src/solid/devices/backends/udev/udevmanager.cpp <span style="color: \
grey">(3f3a671798e84e6d577df7c3b9b80150ac4d01fc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128083/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3073064946115710041==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 