'Re: Review Request 127896: make dbus optional on osx: kauth'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-frameworks-devel
Subject: Re: Review Request 127896: make dbus optional on osx: kauth
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2016-05-21 21:07:44
Message-ID: 20160521210744.15344.84586 () mimi ! kde ! org
[Download RAW message or body]

--===============8292451364123098424==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On May 21, 2016, 10:20 p.m., Kåre Särs wrote:
> > CMakeLists.txt, line 12
> > <https://git.reviewboard.kde.org/r/127896/diff/3/?file=465312#file465312line12>
> > 
> > Why is this not: option(DISABLE_DBUS "Remove..." OFF) ?
> > 
> > For the rest I'm happy :)

Idem.

Isn't there a guideline against negative options? IOW, wouldn't it be better to have \
something like

`option(INCLUDE_DBUS_SUPPORT "Include support for using DBus to ..." ON)`

so that you don't have to test on `NOT FOO` everywhere?

(I know it's common practice to use shortcuts like "--disable-dbus" to indicate \
"disable support for dbus", but we can just as well use an option name that's \
semantically correct, no? :) )

- René J.V.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127896/#review95681
-----------------------------------------------------------

On May 20, 2016, 11:13 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127896/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 11:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and \
> Martin Gräßlin. 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> this is the first patch to make kde frameworks build (and then work) without dbus.
> 
> this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. \
> as dbus is not a common service in osx world, kde apps on osx should use native \
> means for interprocess communication instead -- this will make them better citizens \
> in osx ecosystem. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 48dc2d9 
> autotests/BackendsManager.cpp 59675b3 
> autotests/CMakeLists.txt b53d760 
> autotests/HelperTest.cpp 8050a06 
> src/CMakeLists.txt 1b6930d 
> src/ConfigureChecks.cmake d46761a 
> 
> Diff: https://git.reviewboard.kde.org/r/127896/diff/
> 
> 
> Testing
> -------
> 
> compiles fine on osx, compiles fine on linux, tests on linux still pass.
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
> 

--===============8292451364123098424==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127896/">https://git.reviewboard.kde.org/r/127896/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 21st, 2016, 10:20 p.m. CEST, <b>Kåre \
Särs</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/127896/diff/3/?file=465312#file465312line12" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">12</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">set(DISABLE_DBUS FALSE CACHE BOOL &quot;Remove DBus from dependencies \
list&quot;)</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
is this not: option(DISABLE_DBUS "Remove..." OFF) ?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
the rest I'm happy :)</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Idem. Isn't there a guideline against \
negative options? IOW, wouldn't it be better to have something like <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">option(INCLUDE_DBUS_SUPPORT "Include support \
for using DBus to ..." ON)</code> so that you don't have \
to test on <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">NOT FOO</code> everywhere? \
(I know it's common practice to use shortcuts like \
"--disable-dbus" to indicate "disable support for dbus", but we can just as well use \
an option name that's semantically correct, no? :) )</pre>

<p>- René J.V.</p>

<br />
<p>On May 20th, 2016, 11:13 p.m. CEST, Nick Shaforostoff wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, \
and Martin Gräßlin.</div> <div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated May 20, 2016, 11:13 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is the first patch to make kde frameworks build \
(and then work) without dbus.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">this will allow \
homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a \
common service in osx world, kde apps on osx should use native means for interprocess \
communication instead -- this will make them better citizens in osx \
ecosystem.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles fine on osx, compiles fine on linux, tests on \
linux still pass.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(48dc2d9)</span></li>

 <li>autotests/BackendsManager.cpp <span style="color: grey">(59675b3)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: grey">(b53d760)</span></li>

 <li>autotests/HelperTest.cpp <span style="color: grey">(8050a06)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(1b6930d)</span></li>

 <li>src/ConfigureChecks.cmake <span style="color: grey">(d46761a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127896/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8292451364123098424==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 