'Re: Review Request 127923: Add support for custom emoticon sizes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127923: Add support for custom emoticon sizes
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2016-05-17 23:56:00
Message-ID: 20160517235600.6629.59867 () mimi ! kde ! org
[Download RAW message or body]

--===============8435328316588091422==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127923/
-----------------------------------------------------------

(Updated May 17, 2016, 4:56 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and David Gil Oliva.

Changes
-------

Submitted with commit f00115a9bb0ddf48d0a34b737583e9d72c5013dd by Martin Klapetek to \
branch master.

Repository: kemoticons

Description
-------

Right now KEmoticonTheme::parse always returns the emoticons
sized by the actual image file size, but there are cases where
different size is needed, for example when parsing emoticons
inline in a text area while typing.

This also allows to ship bigger emoticon images and have them
scaled down as/when needed.

Diffs
-----

  autotests/kemoticontest.cpp 4e0e539 
  src/core/kemoticons.h 4718c00 
  src/core/kemoticons.cpp 9756c1f 
  src/core/kemoticonsprovider.h d259bf8 
  src/core/kemoticonsprovider.cpp 5aabd82 

Diff: https://git.reviewboard.kde.org/r/127923/diff/

Testing
-------

Works as expected plus comes with a simple autotest.

Thanks,

Martin Klapetek

--===============8435328316588091422==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127923/">https://git.reviewboard.kde.org/r/127923/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Gil Oliva.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated May 17, 2016, 4:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit f00115a9bb0ddf48d0a34b737583e9d72c5013dd by Martin \
Klapetek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Right now KEmoticonTheme::parse always returns the \
emoticons sized by the actual image file size, but there are cases where
different size is needed, for example when parsing emoticons
inline in a text area while typing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This also allows to ship bigger emoticon images and \
have them scaled down as/when needed.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works as expected plus comes with a simple \
autotest.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kemoticontest.cpp <span style="color: grey">(4e0e539)</span></li>

 <li>src/core/kemoticons.h <span style="color: grey">(4718c00)</span></li>

 <li>src/core/kemoticons.cpp <span style="color: grey">(9756c1f)</span></li>

 <li>src/core/kemoticonsprovider.h <span style="color: grey">(d259bf8)</span></li>

 <li>src/core/kemoticonsprovider.cpp <span style="color: grey">(5aabd82)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127923/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8435328316588091422==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 