[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application meta
From: Michael Pyne <mpyne () kde ! org>
Date: 2016-05-04 3:40:36
Message-ID: 20160504034036.6730.80423 () mimi ! kde ! org
[Download RAW message or body]
--===============4417839239177902259==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127655/#review95147
-----------------------------------------------------------
Fix it, then Ship it!
A couple of minor things but this will work nicely. Good idea on leaving the comment \
for things to do in KF6 as well... it's probably better to defer entirely to \
QCoreApplication, especially since plugins provide their own metadata separately \
anyways. But that's a discussion for later.
autotests/kaboutdatatest.cpp (line 317)
<https://git.reviewboard.kde.org/r/127655/#comment64572>
Doesn't this call make the KAboutData::applicationData() call that happens later \
return *this* "aboutData" object (contrary to its comment)?
Might be better to combine these two test cases into one that sets the Qt data, \
verifies it's picked up into a KAboutData, and then with a new KAboutData object, \
calls setApplicationData and verifies that the QCoreApplication data settings are \
updated.
src/lib/kaboutdata.cpp (line 925)
<https://git.reviewboard.kde.org/r/127655/#comment64571>
Please either make this a static function or place it in an anonymous namespace, \
no need to make this symbol visible in the compiled object file or library.
- Michael Pyne
On May 3, 2016, 12:39 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127655/
> -----------------------------------------------------------
>
> (Updated May 3, 2016, 12:39 a.m.)
>
>
> Review request for KDE Frameworks, Alex Richardson and Michael Pyne.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> There is code in e.g. KXMLGUI which relies on KAboutData::applicationData(), \
> without requiring the user to use KAboutData::setApplicationData(). So better be \
> complete when initializing the data from the Q*Application metadata.
> Also
> - warn if there is no Q*App instance yet to set properties in \
> KAboutData::setApplicationData
> - check and warn if KAboutData::applicationData is out-of-sync with qapp data
> - remove bogus check for empty display name, as the method defaults to \
> componentname
> - unit tests KAboutDataTest::testSetOfQApplicationData/testPickupOfQApplicationData
>
>
> Diffs
> -----
>
> autotests/kaboutdatatest.cpp f31e7f3
> src/lib/kaboutdata.h 97c0f2b
> src/lib/kaboutdata.cpp ceb0c06
>
> Diff: https://git.reviewboard.kde.org/r/127655/diff/
>
>
> Testing
> -------
>
> Added autotests pass.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
--===============4417839239177902259==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127655/">https://git.reviewboard.kde.org/r/127655/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A couple of minor things \
but this will work nicely. Good idea on leaving the comment for things to do in KF6 \
as well... it's probably better to defer entirely to QCoreApplication, especially \
since plugins provide their own metadata separately anyways. But that's a \
discussion for later.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127655/diff/2/?file=462407#file462407line317" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/kaboutdatatest.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">317</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KAboutData</span><span class="o">::</span><span \
class="n">setApplicationData</span><span class="p">(</span><span \
class="n">aboutData</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't this call \
make the KAboutData::applicationData() call that happens later return *this* \
"aboutData" object (contrary to its comment)?
Might be better to combine these two test cases into one that sets the Qt data, \
verifies it's picked up into a KAboutData, and then with a new KAboutData object, \
calls setApplicationData and verifies that the QCoreApplication data settings are \
updated.</pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127655/diff/2/?file=462409#file462409line925" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/kaboutdata.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">925</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">warnIfOutOfSync</span><span \
class="p">(</span><span class="k">const</span> <span class="kt">char</span> <span \
class="o">*</span><span class="n">aboutDataString</span><span class="p">,</span> \
<span class="k">const</span> <span class="n">QString</span> <span \
class="o">&</span><span class="n">aboutDataValue</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please either make this \
a static function or place it in an anonymous namespace, no need to make this symbol \
visible in the compiled object file or library.</pre> </div>
</div>
<br />
<p>- Michael Pyne</p>
<br />
<p>On May 3rd, 2016, 12:39 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Alex Richardson and Michael Pyne.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated May 3, 2016, 12:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is code in e.g. KXMLGUI which relies on \
KAboutData::applicationData(), without requiring the user to use \
KAboutData::setApplicationData(). So better be complete when initializing the data \
from the Q*Application metadata.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Also
- warn if there is no Q*App instance yet to set properties in \
KAboutData::setApplicationData
- check and warn if KAboutData::applicationData is out-of-sync with qapp data
- remove bogus check for empty display name, as the method defaults to componentname
- unit tests KAboutDataTest::testSetOfQApplicationData/testPickupOfQApplicationData</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added autotests pass.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kaboutdatatest.cpp <span style="color: grey">(f31e7f3)</span></li>
<li>src/lib/kaboutdata.h <span style="color: grey">(97c0f2b)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(ceb0c06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127655/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4417839239177902259==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic