[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definit
From: Andrius da Costa Ribas <andriusmao () gmail ! com>
Date: 2016-04-23 23:55:49
Message-ID: 20160423235549.31741.1314 () mimi ! kde ! org
[Download RAW message or body]
--===============7422254450984832620==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Abril 23, 2016, 11:40 p.m., Michael Pyne wrote:
> > This is a duplicate of RR 127598, which is about to get marked as 'change then \
> > commit' (I missed that it was updated a few days ago when my email was futzy :( \
> > ).
Thanks! I'm discarding this one, then.
- Andrius da Costa
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/#review94797
-----------------------------------------------------------
On Abril 23, 2016, 11:54 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127729/
> -----------------------------------------------------------
>
> (Updated Abril 23, 2016, 11:54 p.m.)
>
>
> Review request for KDE Frameworks and kdewin.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Although there is currently no problem on building kcoreaddons, when building \
> okular (and possibly other apps) the compiler gets confused when it reaches \
> std::numeric_limits<uint>::max() as <windows.h> is also included and it defines a \
> 'max' macro.
>
> Diffs
> -----
>
> src/lib/util/kuser.h 3c9ff00
>
> Diff: https://git.reviewboard.kde.org/r/127729/diff/
>
>
> Testing
> -------
>
> Okular is buildable on MSVC after this patch. No further testing done.
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
--===============7422254450984832620==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127729/">https://git.reviewboard.kde.org/r/127729/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Abril 23rd, 2016, 11:40 p.m. UTC, <b>Michael \
Pyne</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a duplicate of RR 127598, which is about to get marked as \
'change then commit' (I missed that it was updated a few days ago when my \
email was futzy :( ).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks! I'm discarding this one, then.</p></pre> <br />
<p>- Andrius da Costa</p>
<br />
<p>On Abril 23rd, 2016, 11:54 p.m. UTC, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Abril 23, 2016, 11:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Although there is currently no problem on building \
kcoreaddons, when building okular (and possibly other apps) the compiler gets \
confused when it reaches std::numeric_limits<uint>::max() as <windows.h> \
is also included and it defines a 'max' macro.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Okular is buildable on MSVC after this patch. No \
further testing done.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/util/kuser.h <span style="color: grey">(3c9ff00)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127729/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7422254450984832620==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic