'Re: Review Request 127714: Enable ICO and EXE thumbnails again.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request 127714: Enable ICO and EXE thumbnails again.
From:       Andrius da Costa Ribas <andriusmao () gmail ! com>
Date:       2016-04-23 15:21:25
Message-ID: 20160423152125.31741.79813 () mimi ! kde ! org
[Download RAW message or body]

--===============4168184841476652942==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
-----------------------------------------------------------

(Updated April 23, 2016, 8:21 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and kdewin.

Changes
-------

Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by Andrius da Costa \
Ribas to branch master.

Repository: kio-extras

Description
-------

These had been disabled when moving into frameworks.

Diffs
-----

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/

Testing
-------

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working (with \
wrestool binary from (**aaargh!!**) cygwin).

File Attachments
----------------

Native Version
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
 Icoutils Version
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png

Thanks,

Andrius da Costa Ribas

--===============4168184841476652942==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127714/">https://git.reviewboard.kde.org/r/127714/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>

<p style="color: grey;"><i>Updated April 23, 2016, 8:21 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by \
Andrius da Costa Ribas to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">These had been disabled when moving into \
frameworks.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested using MSVC 2015 64bit.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, \
faked a non-win32 setup to ensure the icoutils version is also working (with wrestool \
binary from (<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">aaargh!!</strong>) cygwin).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>thumbnail/CMakeLists.txt <span style="color: grey">(6a6ecc7)</span></li>

 <li>thumbnail/windowsexecreator.cpp <span style="color: grey">(f823597)</span></li>

 <li>thumbnail/windowsimagecreator.cpp <span style="color: \
grey">(cb110f3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127714/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png">Native \
Version</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png">Icoutils \
Version</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4168184841476652942==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 