[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127632: Prioritize correct extension per theme
From: Nick Shaforostoff <shafff () ukr ! net>
Date: 2016-04-22 10:40:52
Message-ID: 20160422104052.31741.65396 () mimi ! kde ! org
[Download RAW message or body]
--===============2465256475904870495==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94759
-----------------------------------------------------------
Ship it!
i think adhering spec here is not very important.
we can adopt this change now, mention this somewhere in docs (print a qWarning saying \
that the checking order has changed?), and introduce X-KDE-Extensions later (which \
would only require a slght adjustment of iconPathByName() method).
- Nick Shaforostoff
On April 11, 2016, 11:17 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 11:17 p.m.)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to \
> bindly use an extensions vector that is statically defined.
> Prioritizes the extensions that work, so it will find the icons sooner.
>
>
> Diffs
> -----
>
> src/kiconloader.cpp 37528ad
> src/kicontheme.h 3190665
> src/kicontheme.cpp e7e003b
>
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
>
>
> Testing
> -------
>
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's \
> almost as good as the RR #127236, but with a much smaller memory impact, since \
> we're not caching all the icon names (which was specially bad as it was \
> per-process). ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============2465256475904870495==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127632/">https://git.reviewboard.kde.org/r/127632/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i \
think adhering spec here is not very important.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we \
can adopt this change now, mention this somewhere in docs (print a qWarning saying \
that the checking order has changed?), and introduce X-KDE-Extensions later (which \
would only require a slght adjustment of iconPathByName() method).</p></pre> <br />
<p>- Nick Shaforostoff</p>
<br />
<p>On April 11th, 2016, 11:17 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated April 11, 2016, 11:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Usually themes will have 1 kind of extension (2 tops) \
it doesn't make sense to bindly use an extensions vector that is statically \
defined.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Prioritizes the extensions that work, so it will find \
the icons sooner.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds and tests still pass. Also reducess faulty disk \
accesses to its 45%. Note that by this metric, it's almost as good as the RR #127236, \
but with a much smaller memory impact, since we're not caching all the icon names \
(which was specially bad as it was per-process).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span \
style="color: #19177C">$ </span>strace kwrite |& grep ENOENT | wc -l 4699
<span style="color: #19177C">$ </span>strace kwrite |& grep ENOENT | wc -l
2119
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kiconloader.cpp <span style="color: grey">(37528ad)</span></li>
<li>src/kicontheme.h <span style="color: grey">(3190665)</span></li>
<li>src/kicontheme.cpp <span style="color: grey">(e7e003b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127632/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2465256475904870495==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic