'Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed i'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed i
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-04-17 18:03:52
Message-ID: 20160417180352.10515.26029 () mimi ! kde ! org
[Download RAW message or body]

--===============4642813889120086848==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127666/#review94670
-----------------------------------------------------------

That's not correct. One must be able to be sure that if he sets an URL, he'll get an \
URL.

- Aleix Pol Gonzalez

On April 17, 2016, 1:09 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127666/
> -----------------------------------------------------------
> 
> (Updated April 17, 2016, 1:09 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed setting (it \
> may contain only local paths). this patch makes sure that no file:// prefix is \
> added on setting change by adding a special check for the case when qvariant \
> contains qurl and converting it appropriately 
> 
> Diffs
> -----
> 
> src/core/kcoreconfigskeleton.cpp 293387b 
> 
> Diff: https://git.reviewboard.kde.org/r/127666/diff/
> 
> 
> Testing
> -------
> 
> ktorrent now displays local paths in settings dialog without file:// prefix
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
> 

--===============4642813889120086848==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127666/">https://git.reviewboard.kde.org/r/127666/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's not correct. One must be able to be sure that if he sets an URL, \
he'll get an URL.</p></pre>  <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On April 17th, 2016, 1:09 p.m. CEST, Nick Shaforostoff wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated April 17, 2016, 1:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed \
setting (it may contain only local paths). this patch makes sure that no file:// \
prefix is added on setting change by adding a special check for the case when \
qvariant contains qurl and converting it appropriately</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ktorrent now displays local paths in settings dialog \
without file:// prefix</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kcoreconfigskeleton.cpp <span style="color: grey">(293387b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127666/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4642813889120086848==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 