'Re: Review Request 127586: [calendar] Add a mark to days containing events'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127586: [calendar] Add a mark to days containing events
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2016-04-15 2:28:12
Message-ID: 20160415022812.15182.61585 () mimi ! kde ! org
[Download RAW message or body]

--===============0273617533751019675==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
-----------------------------------------------------------

(Updated April 15, 2016, 4:28 a.m.)

Review request for KDE Frameworks and Plasma.

Changes
-------

Replace the Canvas with SvgItem

Repository: plasma-framework

Description
-------

Simple triangle at the bottom right corner, see screenshot.

Diffs (updated)
-----

  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/

Testing
-------

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png

Thanks,

Martin Klapetek

--===============0273617533751019675==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127586/">https://git.reviewboard.kde.org/r/127586/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated April 15, 2016, 4:28 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace the Canvas with SvgItem</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Simple triangle at the bottom right corner, see \
screenshot.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/calendar/daysmodel.h <span style="color: \
grey">(8ab232e)</span></li>

 <li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: \
grey">(bf99874)</span></li>

 <li>src/declarativeimports/calendar/qml/DayDelegate.qml <span style="color: \
grey">(6353827)</span></li>

 <li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(d4b8fe4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127586/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0273617533751019675==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 