[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    =?UTF-8?Q?Re=3A_Jenkins=2Dkde=2Dci=3A_kiconthemes_master_kf5=2Dqt5_=C2=BB_Li?= =?UTF-8?Q?nux=2Cgcc_=
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2016-04-10 22:15:53
Message-ID: CACcA1Rr1EkTEL+e2+Fw2vxiFRiCp+BZxxEJeJe1nOcKbd4gSPw () mail ! gmail ! com
[Download RAW message or body]

On Mon, Apr 11, 2016 at 12:06 AM, David Faure <faure@kde.org> wrote:
> ********* Start testing of KIconLoader_Benchmark *********
> Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared \
> (dynamic) debug build; by GCC 5.2.1 20151010) PASS   : \
> KIconLoader_Benchmark::initTestCase() FAIL!  : KIconLoader_Benchmark::benchmark() \
>                 '!icon.isNull()' returned FALSE. ()
> Loc: [/home/jenkins/sources/kiconthemes/kf5-qt5/autotests/kiconloader_benchmark.cpp(81)]
>  PASS   : KIconLoader_Benchmark::cleanupTestCase()
> Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
> ********* Finished testing of KIconLoader_Benchmark *********
> 
> I guess the dependency on an actual icon theme (breeze or oxygen) is missing in the \
> CI. 
> The other unittest creates its own small fake theme so that it's standalone.
> But this one would need a lot of icons in the fake theme :-)
> 
> Maybe it's enough to make it exit early if the first icon can't be loaded,
> a benchmark is only useful when a human is looking at it anyway.
> 
> On Sunday 10 April 2016 22:00:05 no-reply@kde.org wrote:
> > 
> > GENERAL INFO
> > 
> > BUILD UNSTABLE
> > Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
> >                 
> > Project: PLATFORM=Linux,compiler=gcc
> > Date of build: Sun, 10 Apr 2016 21:57:59 +0000
> > Build duration: 1 min 5 sec
> > 
> > CHANGE SET
> > Revision da3afe6840bf4974bd8d022b86fb9778f2af8688 by aleixpol: (Save some disk \
> >                 accesses)
> > change: edit autotests/kiconloader_unittest.cpp
> > change: add autotests/kiconloader_benchmark.cpp
> > change: edit autotests/CMakeLists.txt
> > change: edit src/kiconloader.cpp
> > Revision 5c1d737796e8a1cebcba671217ad519971e0894b by aleixpol: (Properly call \
> >                 QDir::entryList)
> > change: edit src/kicontheme.cpp
> > 
> > 
> > JUNIT RESULTS
> > 
> > Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 \
> > test(s)Failed: TestSuite.kiconthemes-kiconloader_benchmark 
> > COBERTURA RESULTS
> > 
> > Cobertura Coverage Report
> > PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2324 \
> > (44%)CONDITIONAL 656/1011 (65%) 
> > By packages
> > 
> > autotests
> > FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 348/350 (99%)CONDITIONAL 204/394 (52%)
> > src
> > FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 686/1974 (35%)CONDITIONAL 452/617 (73%)
> 
> --
> David Faure, faure@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
> 

Hi David,
I guess it makes sense. Here's a fix:
http://commits.kde.org/kiconthemes/43b8ab28903d8a4a96184e10a4efda868f06b96e

Aleix
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread]