[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126161: OS X housekeeping
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2016-04-06 17:15:39
Message-ID: 20160406171539.15005.15141 () mimi ! kde ! org
[Download RAW message or body]
--===============6215629614859760476==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126161/
-----------------------------------------------------------
(Updated April 6, 2016, 7:15 p.m.)
Review request for KDE Software on Mac OS X and KDE Frameworks.
Changes
-------
It's been a while!
This new version drops the possibility to launch from shared libraries on OS X, and \
thus no longer needs a launcher proxy. For now I've kept most of the code unchanged, \
meaning that kdeinit5 still forks before exec'ing the requested application. This is \
safe, so it has the advantage of following the regular Unix variant as closely as \
possible.
Tested against K5W 5.20.0, patch against git/head.
Repository: kinit
Description
-------
This patch addresses several issues with the OS X adaptations:
-1 replaces the obsolete Q_OS_MAC with Q_OS_OSX
-2 builds the relevant applications `nongui` instead of as app bundles
-3 turns klauncher into an "agent" by setting `LSUIElement` to true programmatically
-4 ports a patch that has been in MacPorts' `port:kdelibs4` since October 14th 2009, \
which prevents a kdeinit crash that is caused by calling exec after `fork()` in an \
application that has used non-POSIX APIs and/or calling those APIs in the exec'ed \
application. This patch (originally by MacPorts developers Jeremy Lainé and Jeremy \
Lavergne) rearranges call order and uses a proxy application to do the actual exec.
Diffs (updated)
-----
src/kdeinit/CMakeLists.txt ae619f7
src/kdeinit/kinit.cpp ca18603
src/kdeinit/kinit_mac.mm PRE-CREATION
src/klauncher/CMakeLists.txt a8e6c3e
src/klauncher/klauncher.h 53c0803
src/klauncher/klauncher.cpp baa5649
src/klauncher/klauncher_main.cpp 710c889
src/start_kdeinit/CMakeLists.txt 46d6cb3
src/wrapper.cpp 9cb0a71
Diff: https://git.reviewboard.kde.org/r/126161/diff/
Testing
-------
On OS X 10.9.5 with Qt 5.5.1 and KF5rameworks 5.16.0 . With this patch, starting \
`kded5` will launch kdeinit5 and klauncher5 as expected, but `kdeinit5 --kded` does \
not yet launch `kded5`. This is probably acceptable for typical KF5 use on OS X \
(kded5 can be launched as a login item or as a LaunchAgent) but I will have another \
look at why the kded isn't started.
I am not yet able to perform further testing; practice will for instance have to show \
whether point 2 above needs revision (apps that need to be installed as app bundles).
Similarly it will have to be seen whether point 3 above has any drawbacks. \
Applications running as agents do not show up in the Dock or App Switcher. Thus, \
klauncher will not be able to "turn itself into" an application that does have a full \
GUI presence with my current modification. I don't know if that's supposed to be \
possible though.
NB: I have been building the KDE4 klauncher in a way that makes it impossible to \
construct a GUI at all, so I'm not expecting issues in KF5 as long as klauncher's \
role hasn't evolved too much.
Thanks,
René J.V. Bertin
--===============6215629614859760476==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126161/">https://git.reviewboard.kde.org/r/126161/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDE Frameworks.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated April 6, 2016, 7:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It's been a while!
This new version drops the possibility to launch from shared libraries on OS X, and \
thus no longer needs a launcher proxy. For now I've kept most of the code \
unchanged, meaning that kdeinit5 still forks before exec'ing the requested \
application. This is safe, so it has the advantage of following the regular Unix \
variant as closely as possible.
Tested against K5W 5.20.0, patch against git/head.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch addresses several issues with the OS X \
adaptations:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-1 replaces the obsolete Q_OS_MAC with \
Q_OS_OSX
-2 builds the relevant applications <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">nongui</code> \
instead of as app bundles
-3 turns klauncher into an "agent" by setting <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">LSUIElement</code> to true programmatically
-4 ports a patch that has been in MacPorts' <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">port:kdelibs4</code> since October 14th 2009, which prevents a kdeinit \
crash that is caused by calling exec after <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">fork()</code> in an application that has used non-POSIX APIs and/or calling \
those APIs in the exec'ed application. This patch (originally by MacPorts developers \
Jeremy Lainé and Jeremy Lavergne) rearranges call order and uses a proxy application \
to do the actual exec.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 with Qt 5.5.1 and KF5rameworks 5.16.0 . \
With this patch, starting <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kded5</code> \
will launch kdeinit5 and klauncher5 as expected, but <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kdeinit5 --kded</code> does not yet launch <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kded5</code>. This is probably acceptable for typical KF5 use on OS X \
(kded5 can be launched as a login item or as a LaunchAgent) but I will have another \
look at why the kded isn't started.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I am not yet able to \
perform further testing; practice will for instance have to show whether point 2 \
above needs revision (apps that need to be installed as app bundles).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Similarly it will have to be seen whether point 3 above has any drawbacks. \
Applications running as agents do not show up in the Dock or App Switcher. Thus, \
klauncher will not be able to "turn itself into" an application that does have a full \
GUI presence with my current modification. I don't know if that's supposed to be \
possible though.
NB: I have been building the KDE4 klauncher in a way that makes it impossible to \
construct a GUI at all, so I'm not expecting issues in KF5 as long as klauncher's \
role hasn't evolved too much.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdeinit/CMakeLists.txt <span style="color: grey">(ae619f7)</span></li>
<li>src/kdeinit/kinit.cpp <span style="color: grey">(ca18603)</span></li>
<li>src/kdeinit/kinit_mac.mm <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/klauncher/CMakeLists.txt <span style="color: grey">(a8e6c3e)</span></li>
<li>src/klauncher/klauncher.h <span style="color: grey">(53c0803)</span></li>
<li>src/klauncher/klauncher.cpp <span style="color: grey">(baa5649)</span></li>
<li>src/klauncher/klauncher_main.cpp <span style="color: grey">(710c889)</span></li>
<li>src/start_kdeinit/CMakeLists.txt <span style="color: grey">(46d6cb3)</span></li>
<li>src/wrapper.cpp <span style="color: grey">(9cb0a71)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126161/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6215629614859760476==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic