[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-03-23 10:55:04
Message-ID: 20160323105504.21226.45500 () mimi ! kde ! org
[Download RAW message or body]
--===============0326260591339071308==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On März 21, 2016, 8:42 nachm., Dominik Haumann wrote:
> > ping
>
> Marco Martin wrote:
> +1, to me the latest version could be fine, would like a last word from \
> windowmanager people tough
As mentioned, I ceased to care.
I'm providing input while phasing out (and promise it to be on best knowledge) but \
won't take decisions which do no longer affect me in their consequences.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93837
-----------------------------------------------------------
On März 20, 2016, 12:06 nachm., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> -----------------------------------------------------------
>
> (Updated März 20, 2016, 12:06 nachm.)
>
>
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags were \
> change from Qt::ToolTip to Qt::Window.
> As consequence, the completion popup of the Kate command line gets a full window \
> decoration, which is obviously wrong, see attached screenshot.
> Changing the type to Qt::Popup shows the proper popup, but key presses are not \
> forwarded, so typing is not possible, and additionally, on losing focus the popup \
> keeps staying open. Therefore, this patch reverts the type back to Qt::ToolTip.
>
> Better fixes are of course welcome ;) Any ideas?
>
>
> Diffs
> -----
>
> src/kcompletionbox.cpp 005aff8
>
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
>
>
> Testing
> -------
>
> Works on Windows as expected.
>
>
> File Attachments
> ----------------
>
> Completion Popup
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
>
>
> Thanks,
>
> Dominik Haumann
>
>
--===============0326260591339071308==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127424/">https://git.reviewboard.kde.org/r/127424/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On März 21st, 2016, 8:42 nachm. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ping</p></pre> </blockquote>
<p>On März 23rd, 2016, 10:38 vorm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1, \
to me the latest version could be fine, would like a last word from windowmanager \
people tough</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
mentioned, I ceased to care. I'm providing input while phasing out (and promise it to \
be on best knowledge) but won't take decisions which do no longer affect me in their \
consequences.</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On März 20th, 2016, 12:06 nachm. UTC, Dominik Haumann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.</div>
<div>By Dominik Haumann.</div>
<p style="color: grey;"><i>Updated März 20, 2016, 12:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In https://git.reviewboard.kde.org/r/127191/ the \
KCompletionBox WindowFlags were change from Qt::ToolTip to Qt::Window.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">As consequence, the completion popup of the Kate command line gets a full \
window decoration, which is obviously wrong, see attached screenshot.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Changing the type to Qt::Popup shows the proper popup, but key presses are \
not forwarded, so typing is not possible, and additionally, on losing focus the popup \
keeps staying open. Therefore, this patch reverts the type back to Qt::ToolTip.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Better fixes are of course welcome ;) Any \
ideas?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works on Windows as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcompletionbox.cpp <span style="color: grey">(005aff8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127424/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png">Completion \
Popup</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0326260591339071308==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic