'Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on 
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-03-06 13:30:33
Message-ID: 20160306133033.10537.18620 () mimi ! kde ! org
[Download RAW message or body]

--===============7208251543779347204==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/
-----------------------------------------------------------

(Updated Март 6, 2016, 3:30 след обяд)

Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin \
Klapetek.

Changes
-------

This starts to work on most cases. But things getting weard again, if you use restore \
previous session and logout/in automatically started app *not* work. If you restart \
it, all works. Looks like knotification is not used who *confuse* me more.

Bugs: 356523
    https://bugs.kde.org/show_bug.cgi?id=356523

Repository: knotifications

Description
-------

Store position of widget before hide it

Diffs (updated)
-----

  src/kstatusnotifieritem.cpp cf3e7b5 
  src/kstatusnotifieritemprivate_p.h 8fdfd4c 

Diff: https://git.reviewboard.kde.org/r/127216/diff/

Testing
-------

Tested on pixel ration = 1

Thanks,

Anthony Fieroni

--===============7208251543779347204==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127216/">https://git.reviewboard.kde.org/r/127216/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin \
Klapetek.</div> <div>By Anthony Fieroni.</div>

<p style="color: grey;"><i>Updated Март 6, 2016, 3:30 след обяд</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This starts to work on most cases. But things getting weard again, if \
you use restore previous session and logout/in automatically started app *not* work. \
If you restart it, all works. Looks like knotification is not used who *confuse* me \
more.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=356523">356523</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Store position of widget before hide it</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on pixel ration = 1</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kstatusnotifieritem.cpp <span style="color: grey">(cf3e7b5)</span></li>

 <li>src/kstatusnotifieritemprivate_p.h <span style="color: \
grey">(8fdfd4c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127216/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7208251543779347204==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 