[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation
From: Andre Heinecke <aheinecke () intevation ! de>
Date: 2016-03-04 15:36:26
Message-ID: 20160304153626.32153.25044 () mimi ! kde ! org
[Download RAW message or body]
--===============2071105712278938253==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 4, 2016, 3:01 p.m., Chusslove Illich wrote:
> > src/klocalizedstring.cpp, line 368
> > <https://git.reviewboard.kde.org/r/127275/diff/1/?file=447946#file447946line368>
> >
> > I would nevertheless ifdef it. It may be that some strange thing is intentionally \
> > done with locale variables (e.g. to test something or kill localization), and \
> > then the behavior would deviate from that documented for Gettext.
I'm assuming that QLocale::system() is also changed accodingly in that case so I \
don't think its a problem. The code looks like it's using the same environment \
variables: http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale_unix.cpp#n104
We still have to look at the environment variables in ki18n first because of \
modifier / charset handling, imo otherwise we could just use QLocale here.
For ifdef I would probably do an #infdef O_OS_UNIX instead of a Q_OS_WIN ? I'm not \
sure but I think this probably also makes sense on other platforms like android?
- Andre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/#review93158
-----------------------------------------------------------
On March 4, 2016, 2:53 p.m., Andre Heinecke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127275/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 2:53 p.m.)
>
>
> Review request for KDE Frameworks and Localization and Translation (l10n).
>
>
> Repository: ki18n
>
>
> Description
> -------
>
> The intention for this patch is to fix the inital Language selection for Windows \
> where the environment variables used in Ki18n are not set. This is not a fix for a \
> regression in Ki18n, afaik this never worked on Windows, we had some hacks in \
> Gpg4win to write the language into kdeglobals during installation in kde4 times.
> I don't think this needs to be ifdefed because it only appends so previous language \
> selection is not affected.
>
> Diffs
> -----
>
> src/klocalizedstring.cpp b24fe9b
>
> Diff: https://git.reviewboard.kde.org/r/127275/diff/
>
>
> Testing
> -------
>
> Tested on a german Windows system and got a "de" localized application.
>
>
> Thanks,
>
> Andre Heinecke
>
>
--===============2071105712278938253==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127275/">https://git.reviewboard.kde.org/r/127275/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 4th, 2016, 3:01 p.m. UTC, <b>Chusslove \
Illich</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127275/diff/1/?file=447946#file447946line368" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/klocalizedstring.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">349</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">appendLanguagesFromQLocale</span><span class="p">(</span><span \
class="n">localeLanguages</span><span class="p">,</span> <span \
class="n">QLocale</span><span class="o">::</span><span class="n">system</span><span \
class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would nevertheless \
ifdef it. It may be that some strange thing is intentionally done with locale \
variables (e.g. to test something or kill localization), and then the behavior would \
deviate from that documented for Gettext.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'm assuming that QLocale::system() is also changed accodingly in that case \
so I don't think its a problem. The code looks like it's using the same environment \
variables: http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale_unix.cpp#n104
We still have to look at the environment variables in ki18n first because of \
modifier / charset handling, imo otherwise we could just use QLocale here.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">For ifdef I would probably do an #infdef O_OS_UNIX instead of a Q_OS_WIN ? \
I'm not sure but I think this probably also makes sense on other platforms like \
android?</p></pre> <br />
<p>- Andre</p>
<br />
<p>On March 4th, 2016, 2:53 p.m. UTC, Andre Heinecke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Localization and Translation (l10n).</div>
<div>By Andre Heinecke.</div>
<p style="color: grey;"><i>Updated March 4, 2016, 2:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The intention for this patch is to fix the inital \
Language selection for Windows where the environment variables used in Ki18n are not \
set. This is not a fix for a regression in Ki18n, afaik this never worked on Windows, \
we had some hacks in Gpg4win to write the language into kdeglobals during \
installation in kde4 times.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I don't think this needs to be ifdefed \
because it only appends so previous language selection is not affected.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on a german Windows system and got a "de" \
localized application.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klocalizedstring.cpp <span style="color: grey">(b24fe9b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127275/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2071105712278938253==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic