[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127215: simplify code, reduce pointer dereferences
From: Nick Shaforostoff <shafff () ukr ! net>
Date: 2016-03-02 12:03:22
Message-ID: 20160302120322.32153.78255 () mimi ! kde ! org
[Download RAW message or body]
--===============5120077692953511677==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127215/
-----------------------------------------------------------
(Updated March 2, 2016, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit b9c8b1fadcbb742e6129b77f28336c223a18b424 by Nick Shaforostoff \
to branch master.
Repository: kservice
Description
-------
Changes are mostly related to containers/iterators, but there are also few QString \
related optimizations
note that i have made a switch from QLinkedList to just QList because it performs \
better for T=<void*> also i have changed QStringList to QSet<QString> in one place to \
make the code run faster
Diffs
-----
src/services/kservice.cpp c75bce2
src/services/kservicetype.cpp 2a73ccd
src/sycoca/kbuildmimetypefactory.cpp 340f76a
src/sycoca/kbuildservicefactory.cpp a74f2e8
src/sycoca/kbuildsycoca.cpp e99e906
src/sycoca/kmimeassociations.cpp 9423b27
src/sycoca/ksycocadict.cpp f33d01a
src/sycoca/ksycocafactory.cpp e410581
src/sycoca/ksycocautils_p.h 8db26b0
Diff: https://git.reviewboard.kde.org/r/127215/diff/
Testing
-------
all tests pass, except kmimeassociationstest (fakeApplicationService is NULL), but it \
fails also without my changes
Thanks,
Nick Shaforostoff
--===============5120077692953511677==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127215/">https://git.reviewboard.kde.org/r/127215/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated March 2, 2016, 12:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b9c8b1fadcbb742e6129b77f28336c223a18b424 by Nick \
Shaforostoff to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes are mostly related to containers/iterators, but there are also \
few QString related optimizations
note that i have made a switch from QLinkedList to just QList because it performs \
better for T=<void*> also i have changed QStringList to QSet<QString> in \
one place to make the code run faster</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">all tests pass, except kmimeassociationstest \
(fakeApplicationService is NULL), but it fails also without my changes</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kservice.cpp <span style="color: grey">(c75bce2)</span></li>
<li>src/services/kservicetype.cpp <span style="color: grey">(2a73ccd)</span></li>
<li>src/sycoca/kbuildmimetypefactory.cpp <span style="color: \
grey">(340f76a)</span></li>
<li>src/sycoca/kbuildservicefactory.cpp <span style="color: \
grey">(a74f2e8)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(e99e906)</span></li>
<li>src/sycoca/kmimeassociations.cpp <span style="color: grey">(9423b27)</span></li>
<li>src/sycoca/ksycocadict.cpp <span style="color: grey">(f33d01a)</span></li>
<li>src/sycoca/ksycocafactory.cpp <span style="color: grey">(e410581)</span></li>
<li>src/sycoca/ksycocautils_p.h <span style="color: grey">(8db26b0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127215/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5120077692953511677==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic