'Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-02-26 19:56:32
Message-ID: 20160226195632.22286.70916 () mimi ! kde ! org
[Download RAW message or body]

--===============0710640074442635654==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127023/
-----------------------------------------------------------

(Updated Feb. 26, 2016, 8:56 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, KDEPIM, Daniel Vrátil, Sebastian Kügler, and \
Vishesh Handa.

Changes
-------

Submitted with commit 905bf987247cc1d80c319ab44ccaf0306c714f74 by Kai Uwe Broulik to \
branch master.

Repository: kfilemetadata

Description
-------

This adds support for the user.xdg.origin.email.subject, \
user.xdg.origin.email.sender, user.xdg.origin.email.message-id xattrs [1] to \
KFileMetadata.

This can (should :P) be populated by KMail when you save an attachment.

Not too happy about the "displayName" I chose. Also we'll need to figure out what to \
index and how we can relate this information and present it to the user in a \
meaningful way. But at least let's collect the information first and then we can \
think about ways to handle this.

[1] https://wiki.freedesktop.org/www/CommonExtendedAttributes/

Diffs
-----

  src/properties.h 6ceaca5 
  src/propertyinfo.cpp 4d1fac4 
  src/usermetadata.h 9e10d2a 
  src/usermetadata.cpp 5485d0e 

Diff: https://git.reviewboard.kde.org/r/127023/diff/

Testing
-------

Not really. Tests pass, though.

Thanks,

Kai Uwe Broulik

--===============0710640074442635654==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127023/">https://git.reviewboard.kde.org/r/127023/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, KDEPIM, Daniel Vrátil, Sebastian Kügler, \
and Vishesh Handa.</div> <div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2016, 8:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 905bf987247cc1d80c319ab44ccaf0306c714f74 by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds support for the \
user.xdg.origin.email.subject, user.xdg.origin.email.sender, \
user.xdg.origin.email.message-id xattrs [1] to KFileMetadata.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
can (should :P) be populated by KMail when you save an attachment.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not too happy about the "displayName" I chose. Also we'll need to figure \
out what to index and how we can relate this information and present it to the user \
in a meaningful way. But at least let's collect the information first and then we can \
think about ways to handle this.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] \
https://wiki.freedesktop.org/www/CommonExtendedAttributes/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Not really. Tests pass, though.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/properties.h <span style="color: grey">(6ceaca5)</span></li>

 <li>src/propertyinfo.cpp <span style="color: grey">(4d1fac4)</span></li>

 <li>src/usermetadata.h <span style="color: grey">(9e10d2a)</span></li>

 <li>src/usermetadata.cpp <span style="color: grey">(5485d0e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127023/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0710640074442635654==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 