[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127191: KCompletionBox should *not* be a tooltip
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2016-02-26 13:24:44
Message-ID: 20160226132444.22286.10635 () mimi ! kde ! org
[Download RAW message or body]
--===============2367678169432430490==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127191/#review92807
-----------------------------------------------------------
+1
- Martin Gräßlin
On Feb. 26, 2016, 2:23 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127191/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 2:23 p.m.)
>
>
> Review request for KDE Frameworks and kwin.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> KCompletionbox it's actually more of a combobox popup than a tooltip.
> this sets it the proper type (unfortunately with an hack due the type not being \
> available to Qt::WindowFlags)
> without this, the new morphingpopups KWin effect will animate completion boxes \
> (such as in file open dialog, kate, dolphin adress bar etc)
>
> Diffs
> -----
>
> src/kcompletionbox.cpp 99afc8e
>
> Diff: https://git.reviewboard.kde.org/r/127191/diff/
>
>
> Testing
> -------
>
> Same behavior, due to the Window and bypasswindowmanager that are those two that \
> made the desired behavior when tooltip was picked
>
> Thanks,
>
> Marco Martin
>
>
--===============2367678169432430490==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127191/">https://git.reviewboard.kde.org/r/127191/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p></pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On February 26th, 2016, 2:23 p.m. CET, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2016, 2:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KCompletionbox it's actually more of a combobox popup \
than a tooltip. this sets it the proper type (unfortunately with an hack due the type \
not being available to Qt::WindowFlags)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">without this, the new \
morphingpopups KWin effect will animate completion boxes (such as in file open \
dialog, kate, dolphin adress bar etc)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Same behavior, due to the Window and \
bypasswindowmanager that are those two that made the desired behavior when tooltip \
was picked</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcompletionbox.cpp <span style="color: grey">(99afc8e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127191/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2367678169432430490==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic