[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127046: Move popup menu image actions into a submenu
From: Luigi Toscano <luigi.toscano () tiscali ! it>
Date: 2016-02-22 17:06:11
Message-ID: 20160222170611.16568.42726 () mimi ! kde ! org
[Download RAW message or body]
--===============4805421661987619646==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 12, 2016, 3:37 p.m., Thomas Pfeiffer wrote:
> > I wouldn't say that all actions for images are rarely used.
> > I don't see why viewing, copying or saving an image is less frequently done than \
> > the same things regarding the link. Can't we have those three still on the first \
> > level and then a "More..." option with further actions?
>
> Jonathan Marten wrote:
> I wouldn't have said "rarely used": certainly in my experience I use all of these \
> options occasionally, but nowhere near as often as "Open in new tab", "Save link \
> as", "Open with" etc.
> Obviously any of the image options could appear at the top level instead of in a \
> submenu, but however they are arranged there will be dispute over what should be \
> where. The only sensible options I can think of to satisfy everyone would be \
> "everything at top level" (as of now), or "everything in a submenu" (which groups \
> them all together, provides a place to show the name of the image, and minimises \
> the size of the menu).
What other browsers do?
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/#review92299
-----------------------------------------------------------
On Feb. 11, 2016, 7:18 p.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127046/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 7:18 p.m.)
>
>
> Review request for KDE Frameworks and KDE Usability.
>
>
> Repository: khtml
>
>
> Description
> -------
>
> The popup menu over an image (with actions "Save Image As..." etcetera, see screen \
> shot) has in total 6 image actions which are not frequently used but make the menu \
> very long. Moving these actions onto a submenu makes the top level menu smaller \
> and more logically grouped.
>
> Diffs
> -----
>
> src/khtml_ext.cpp 0f522f4
>
> Diff: https://git.reviewboard.kde.org/r/127046/diff/
>
>
> Testing
> -------
>
> Built KHTML with these changes, tested in Konqueror.
>
>
> File Attachments
> ----------------
>
> Popup menu before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
> Popup menu after
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png
>
>
> Thanks,
>
> Jonathan Marten
>
>
--===============4805421661987619646==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127046/">https://git.reviewboard.kde.org/r/127046/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 12th, 2016, 3:37 p.m. CET, <b>Thomas \
Pfeiffer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I wouldn't say that all actions for images are rarely \
used. I don't see why viewing, copying or saving an image is less frequently done \
than the same things regarding the link. Can't we have those three still on the first \
level and then a "More..." option with further actions?</p></pre> </blockquote>
<p>On February 22nd, 2016, 6:03 p.m. CET, <b>Jonathan Marten</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't have said \
"rarely used": certainly in my experience I use all of these options \
occasionally, but nowhere near as often as "Open in new tab", "Save \
link as", "Open with" etc.
Obviously any of the image options could appear at the top level instead of in a \
submenu, but however they are arranged there will be dispute over what should be \
where. The only sensible options I can think of to satisfy everyone would be \
"everything at top level" (as of now), or "everything in a \
submenu" (which groups them all together, provides a place to show the name of \
the image, and minimises the size of the menu).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
other browsers do?</p></pre> <br />
<p>- Luigi</p>
<br />
<p>On February 11th, 2016, 7:18 p.m. CET, Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and KDE Usability.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2016, 7:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The popup menu over an image (with actions "Save Image As..." \
etcetera, see screen shot) has in total 6 image actions which are not frequently used \
but make the menu very long. Moving these actions onto a submenu makes the top level \
menu smaller and more logically grouped.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built KHTML with these changes, tested in Konqueror.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/khtml_ext.cpp <span style="color: grey">(0f522f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127046/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png">Popup \
menu before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png">Popup \
menu after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4805421661987619646==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic