[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry
From: Takahiro Hashimoto <kenya888 () gmail ! com>
Date: 2016-02-01 16:54:28
Message-ID: 20160201165428.1720.72108 () mimi ! kde ! org
[Download RAW message or body]
--===============0721517389185923532==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On 2月 1, 2016, 8:18 p.m., David Faure wrote:
> > Ship It!
Thanks!
Sorry, I pushed this commit to remote another branch 'origin/kcoredir'
Could you delete this branch?
- Takahiro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126892/#review91842
-----------------------------------------------------------
On 2月 2, 2016, 1:34 a.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126892/
> -----------------------------------------------------------
>
> (Updated 2月 2, 2016, 1:34 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 358723
> https://bugs.kde.org/show_bug.cgi?id=358723
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The createWizardEntry() can return bool value to know if geting correct URL of new \
> network folder(launching knetattach) failed. Due to the another bug(i'll send a \
> patch for it), a blank entry is inserted to the UDSEntry list and cause to crash \
> app (dolphin, gwenview and others using kcoredirlister) by clicking 'Network' in \
> their placetree view. The empty UDS_NAME is not permmited.
> This fixes the bug by handling result of createWizardEntry().
>
>
> Diffs
> -----
>
> kioslave/remote/kio_remote.cpp ffee08c
>
> Diff: https://git.reviewboard.kde.org/r/126892/diff/
>
>
> Testing
> -------
>
> Confirmed to working fine with dolphin and gwenview (click 'Network' tree)
> And checked that no blank UDS_NAME in their placetree view.
>
> kioslave/remote/tests/testremote has been passed.
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
--===============0721517389185923532==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126892/">https://git.reviewboard.kde.org/r/126892/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On 2月 1st, 2016, 8:18 p.m. JST, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks!</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Sorry, I pushed this commit to remote \
another branch 'origin/kcoredir' Could you delete this branch?</p></pre>
<br />
<p>- Takahiro</p>
<br />
<p>On 2月 2nd, 2016, 1:34 a.m. JST, Takahiro Hashimoto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated 2月 2, 2016, 1:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=358723">358723</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The createWizardEntry() can return bool value to know \
if geting correct URL of new network folder(launching knetattach) failed. Due to the \
another bug(i'll send a patch for it), a blank entry is inserted to the UDSEntry list \
and cause to crash app (dolphin, gwenview and others using kcoredirlister) by \
clicking 'Network' in their placetree view. The empty UDS_NAME is not permmited.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes the bug by handling result of \
createWizardEntry().</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Confirmed to working fine with dolphin and gwenview (click \
'Network' tree) And checked that no blank UDS_NAME in their placetree view.
kioslave/remote/tests/testremote has been passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/remote/kio_remote.cpp <span style="color: grey">(ffee08c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126892/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0721517389185923532==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic