'Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after c'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after c
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-01-24 15:20:49
Message-ID: 20160124152049.17778.39884 () mimi ! kde ! org
[Download RAW message or body]

--===============6898610912665306679==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/
-----------------------------------------------------------

(Updated Ян. 24, 2016, 5:20 след обяд)

Review request for KDE Frameworks, Plasma and David Edmundson.

Bugs: 354353
    http://bugs.kde.org/show_bug.cgi?id=354353

Repository: plasma-framework

Description
-------

Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip animation \
transition between item to decrease it permormance and looks quite ugly. If add new \
panel animation is *cool* as is. The perfermonce decrease can be cause due to swap \
use, or QPropertyAnimation issue, however we (you KDE defs and i *like a user*) wants \
plasmashell and it's components (like panel) to works *forever*

Diffs (updated)
-----

  src/declarativeimports/core/tooltip.cpp a5e223b 
  src/declarativeimports/core/tooltipdialog.h 2ea8af9 
  src/declarativeimports/core/tooltipdialog.cpp 6c3712e 

Diff: https://git.reviewboard.kde.org/r/126870/diff/

Testing
-------

Workaround is quite simple:
Animation is refreshed as is, pointer hasn't same lifetime as panel
+ Animation is disabled if compositing is not active

Thanks,

Anthony Fieroni

--===============6898610912665306679==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126870/">https://git.reviewboard.kde.org/r/126870/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and David Edmundson.</div>
<div>By Anthony Fieroni.</div>

<p style="color: grey;"><i>Updated Ян. 24, 2016, 5:20 след обяд</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=354353">354353</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Continous usage, read as suspend/resume/use and so on, \
cause <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">cool</em> tooltip animation transition between item to \
decrease it permormance and looks quite ugly. If add new panel animation is <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">cool</em> as is. The perfermonce decrease can be cause due to swap use, or \
QPropertyAnimation issue, however we (you KDE defs and i <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">like a \
user</em>) wants plasmashell and it's components (like panel) to works <em \
style="padding: 0;text-rendering:  inherit;margin: 0;line-height: \
inherit;white-space: normal;">forever</em></p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Workaround is quite simple: Animation is refreshed as \
is, pointer hasn't same lifetime as panel + Animation is disabled if compositing is \
not active</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(a5e223b)</span></li>

 <li>src/declarativeimports/core/tooltipdialog.h <span style="color: \
grey">(2ea8af9)</span></li>

 <li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: \
grey">(6c3712e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126870/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6898610912665306679==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 