[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2016-01-19 14:09:42
Message-ID: 20160119140942.4401.17047 () mimi ! kde ! org
[Download RAW message or body]
--===============6648954353107871802==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126725/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 2:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Christoph Feck.
Changes
-------
Submitted with commit 0ea74ebc5ce3e4adcad37b9bb9096988d438848f by René J.V. Bertin \
to branch master.
Repository: kwidgetsaddons
Description
-------
I was seeing a systematic crash on exitting kdenlive5, on OS X deep under the `delete \
menu()` instruction in `KSelectAction::~KSelectAction`. The backtrace suggested this \
might be due to a pending event (or an event due to the menu deletion) being \
delivered post-mortem to an instance of a QMenu related class.
My fix is based on 3 principles:
1) release the "foreign" member instance (`menu()`) before releasing the own d-ptr
2) Remove the QMenu instance from ourselves before deleting it to have one less \
potential dangling reference to it 3) QMenu is a QObject descendent that corresponds \
to a UI element: on OS X it is safer to dispose these through `deleteLater()` rather \
than directly.
Diffs
-----
src/kselectaction.cpp 1381099
Diff: https://git.reviewboard.kde.org/r/126725/diff/
Testing
-------
On OS X 10.9.5, Qt 5.5.1 and KF5 Frameworks 5.16.0, built for installation under \
/opt/local .
It seems that points 1) and 2) above already solve the crash issue in kdenlive on OS \
X, but the general principle stands so I suggest keeping 3) in library code like \
this.
Thanks,
René J.V. Bertin
--===============6648954353107871802==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126725/">https://git.reviewboard.kde.org/r/126725/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2016, 2:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 0ea74ebc5ce3e4adcad37b9bb9096988d438848f by René \
J.V. Bertin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I was seeing a systematic crash on exitting kdenlive5, \
on OS X deep under the <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">delete menu()</code> \
instruction in <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: \
inherit;">KSelectAction::~KSelectAction</code>. The backtrace suggested this might be \
due to a pending event (or an event due to the menu deletion) being delivered \
post-mortem to an instance of a QMenu related class.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
fix is based on 3 principles: 1) release the "foreign" member instance (<code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">menu()</code>) before releasing the own d-ptr 2) Remove the \
QMenu instance from ourselves before deleting it to have one less potential dangling \
reference to it 3) QMenu is a QObject descendent that corresponds to a UI element: on \
OS X it is safer to dispose these through <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">deleteLater()</code> rather than directly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5, Qt 5.5.1 and KF5 Frameworks 5.16.0, \
built for installation under /opt/local .</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems that points 1) \
and 2) above already solve the crash issue in kdenlive on OS X, but the general \
principle stands so I suggest keeping 3) in library code like this.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kselectaction.cpp <span style="color: grey">(1381099)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126725/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6648954353107871802==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic