[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126738: Remove external dependencies from svgs
From: "Dirk Hohndel" <dirk () hohndel ! org>
Date: 2016-01-14 4:51:06
Message-ID: 20160114045106.23702.20396 () mimi ! kde ! org
[Download RAW message or body]
--===============5769247254113958960==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126738/#review91047
-----------------------------------------------------------
this will need to be done for dozens more SVGs - I sent the four that I needed for my \
app for review, but if this change gets accepted I'll volunteer to rewrite all of the \
SVGs that contain external references. It just seemed silly to spend hours doing that \
and then have the project reject the change :-)
- Dirk Hohndel
On Jan. 14, 2016, 1:18 a.m., Dirk Hohndel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126738/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 1:18 a.m.)
>
>
> Review request for KDE Frameworks, andreas kainz and Uri Herrera.
>
>
> Repository: breeze-icons
>
>
> Description
> -------
>
> I don't know what I'm doing here. But when using the icons in a QML app I
> get a lot of warnings like this one:
>
> Could not resolve property : linearGradient4548
>
> Running the svgs through inkscape and using the "clean up document"
> function results in this commit (and the warnings are gone).
>
> This may not be the right thing to do but it would be nice to get rid of
> all these warnings when using the icons.
>
> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
>
>
> Diffs
> -----
>
> icons/actions/24/dialog-cancel.svg a2b022a9dc7b7cf97e4c3391b87e7800355d2dcb
> icons/actions/24/distribute-horizontal-x.svg \
> 262fcaca937cb72d8393fd5dff9c59651367fe36 icons/actions/24/document-edit.svg \
> afb37ca9624b37d6ac5aa9c94f1b2cef620faff6 icons/actions/24/document-save.svg \
> cee0a3521deb7eb1fcb79266afaa8951f4984b20
> Diff: https://git.reviewboard.kde.org/r/126738/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dirk Hohndel
>
>
--===============5769247254113958960==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126738/">https://git.reviewboard.kde.org/r/126738/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
will need to be done for dozens more SVGs - I sent the four that I needed for my app \
for review, but if this change gets accepted I'll volunteer to rewrite all of the \
SVGs that contain external references. It just seemed silly to spend hours doing that \
and then have the project reject the change :-)</p></pre> <br />
<p>- Dirk Hohndel</p>
<br />
<p>On January 14th, 2016, 1:18 a.m. UTC, Dirk Hohndel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, andreas kainz and Uri Herrera.</div>
<div>By Dirk Hohndel.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2016, 1:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-icons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't know what I'm doing here. But when using the icons in a \
QML app I get a lot of warnings like this one:
Could not resolve property : linearGradient4548
Running the svgs through inkscape and using the "clean up document"
function results in this commit (and the warnings are gone).
This may not be the right thing to do but it would be nice to get rid of
all these warnings when using the icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>icons/actions/24/dialog-cancel.svg <span style="color: \
grey">(a2b022a9dc7b7cf97e4c3391b87e7800355d2dcb)</span></li>
<li>icons/actions/24/distribute-horizontal-x.svg <span style="color: \
grey">(262fcaca937cb72d8393fd5dff9c59651367fe36)</span></li>
<li>icons/actions/24/document-edit.svg <span style="color: \
grey">(afb37ca9624b37d6ac5aa9c94f1b2cef620faff6)</span></li>
<li>icons/actions/24/document-save.svg <span style="color: \
grey">(cee0a3521deb7eb1fcb79266afaa8951f4984b20)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126738/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5769247254113958960==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic