'Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2016-01-12 21:40:10
Message-ID: 20160112214010.23702.30305 () mimi ! kde ! org
[Download RAW message or body]

--===============0505731193441471451==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126624/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 10:40 p.m.)

Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.

Changes
-------

This replaces `KGlobalSettings::showIconsOnPushButtons()` with \
`styleHint(SH_DialogButtonBox_ButtonsHaveIcons,btn,widget)`, leaving the actual \
setting lookup to the `Style::styleHint()` function. That means it will show sensible \
behaviour regardless of whether QtCurve is compiled with KF5 enabled or not. It also \
means a note will probably have to be made somewhere in the documentation that the \
QtCurve style generalises the `SH_DialogButtonBox_ButtonsHaveIcons` setting to all \
buttons.

Repository: qtcurve

Description
-------

Implementation details have changed in Qt5 that affect when icons were being shown in \
pushbuttons; as a result, many buttons were drawn with icons visible regardless the \
`ShowIconsInButtons` preference.

This patch implements a solution in the Qt5 style itself, which appears to be the \
only way to respect the preference both robustly (= on all buttons) and reversibly \
(i.e. icons will appear or disappear when toggling the setting without need to \
restart running applications). Buttons that have only an icon but no text will \
continue to show the icon.

Note that `KGlobalSettings::showIconsOnPushButtons()` is deprecated and will have to \
be replaced with something that is not...

Diffs (updated)
-----

  qt5/style/qtcurve_api.cpp 9b7adfa 

Diff: https://git.reviewboard.kde.org/r/126624/diff/

Testing
-------

On OS X 10.9.5 and Linux, both with Qt 5.5.1 and KF5 5.17.0 installed into /opt/local

Thanks,

René J.V. Bertin

--===============0505731193441471451==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126624/">https://git.reviewboard.kde.org/r/126624/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated Jan. 12, 2016, 10:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This replaces `KGlobalSettings::showIconsOnPushButtons()` with \
`styleHint(SH_DialogButtonBox_ButtonsHaveIcons,btn,widget)`, leaving the actual \
setting lookup to the `Style::styleHint()` function. That means it will show sensible \
behaviour regardless of whether QtCurve is compiled with KF5 enabled or not. It also \
means a note will probably have to be made somewhere in the documentation that the \
QtCurve style generalises the `SH_DialogButtonBox_ButtonsHaveIcons` setting to all \
buttons.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implementation details have changed in Qt5 that affect \
when icons were being shown in pushbuttons; as a result, many buttons were drawn with \
icons visible regardless the <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ShowIconsInButtons</code> preference.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch implements a solution in the Qt5 style itself, which appears to be the only way \
to respect the preference both robustly (= on all buttons) and reversibly (i.e. icons \
will appear or disappear when toggling the setting without need to restart running \
applications). Buttons that have only an icon but no text will continue to show the \
icon.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note that <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KGlobalSettings::showIconsOnPushButtons()</code> is deprecated and will \
have to be replaced with something that is not...</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 and Linux, both with Qt 5.5.1 and KF5 \
5.17.0 installed into /opt/local</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>qt5/style/qtcurve_api.cpp <span style="color: grey">(9b7adfa)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126624/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0505731193441471451==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 