[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2016-01-11 15:59:11
Message-ID: 20160111155911.23702.22741 () mimi ! kde ! org
[Download RAW message or body]
--===============1641650660970619248==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote:
> > qt5/style/qtcurve_api.cpp, line 3211
> > <https://git.reviewboard.kde.org/r/126624/diff/1/?file=428407#file428407line3211>
> >
> > Should this be turned on only when KF5 is enabled?
KGlobalSettings is deprecated in KF5.
I recommend quering it from QCommonStyle or KStyle though, they both provide the \
value through `SH_DialogButtonBox_ButtonsHaveIcons`. If none of these aren't bases of \
QtCurve (I don't know about its internals), then the raw KConfig value should be \
queried (See `KStyle` to see how to implement it).
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126624/#review90902
-----------------------------------------------------------
On Jan. 4, 2016, 5:28 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126624/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 5:28 p.m.)
>
>
> Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.
>
>
> Repository: qtcurve
>
>
> Description
> -------
>
> Implementation details have changed in Qt5 that affect when icons were being shown \
> in pushbuttons; as a result, many buttons were drawn with icons visible regardless \
> the `ShowIconsInButtons` preference.
> This patch implements a solution in the Qt5 style itself, which appears to be the \
> only way to respect the preference both robustly (= on all buttons) and reversibly \
> (i.e. icons will appear or disappear when toggling the setting without need to \
> restart running applications). Buttons that have only an icon but no text will \
> continue to show the icon.
> Note that `KGlobalSettings::showIconsOnPushButtons()` is deprecated and will have \
> to be replaced with something that is not...
>
> Diffs
> -----
>
> qt5/style/qtcurve_api.cpp 9b7adfa
>
> Diff: https://git.reviewboard.kde.org/r/126624/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 and Linux, both with Qt 5.5.1 and KF5 5.17.0 installed into \
> /opt/local
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============1641650660970619248==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126624/">https://git.reviewboard.kde.org/r/126624/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 11th, 2016, 4:17 p.m. CET, <b>Yichao \
Yu</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126624/diff/1/?file=428407#file428407line3211" \
style="color: black; font-weight: bold; text-decoration: \
underline;">qt5/style/qtcurve_api.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Style::drawControl(ControlElement element, const QStyleOption *option,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">3211</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
&& !(KGlobalSettings::showIconsOnPushButtons() || btn->text.isEmpty())) \
{</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Should this be turned on only when KF5 is enabled?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KGlobalSettings is deprecated in KF5.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
recommend quering it from QCommonStyle or KStyle though, they both provide the value \
through <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">SH_DialogButtonBox_ButtonsHaveIcons</code>. \
If none of these aren't bases of QtCurve (I don't know about its internals), then the \
raw KConfig value should be queried (See <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStyle</code> \
to see how to implement it).</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On January 4th, 2016, 5:28 p.m. CET, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2016, 5:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implementation details have changed in Qt5 that affect \
when icons were being shown in pushbuttons; as a result, many buttons were drawn with \
icons visible regardless the <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ShowIconsInButtons</code> preference.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch implements a solution in the Qt5 style itself, which appears to be the only way \
to respect the preference both robustly (= on all buttons) and reversibly (i.e. icons \
will appear or disappear when toggling the setting without need to restart running \
applications). Buttons that have only an icon but no text will continue to show the \
icon.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note that <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KGlobalSettings::showIconsOnPushButtons()</code> is deprecated and will \
have to be replaced with something that is not...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 and Linux, both with Qt 5.5.1 and KF5 \
5.17.0 installed into /opt/local</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>qt5/style/qtcurve_api.cpp <span style="color: grey">(9b7adfa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126624/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1641650660970619248==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic