'Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames
From:       "Christoph Cullmann" <cullmann () kde ! org>
Date:       2016-01-10 19:51:17
Message-ID: 20160110195117.23702.86026 () mimi ! kde ! org
[Download RAW message or body]

--===============1203382998458185381==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > <https://git.reviewboard.kde.org/r/125869/diff/1/?file=413338#file413338line6>
> > 
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. We didn't \
> > realize there was a translatable field in these files. Please add support for \
> > translations, like was done for other json files (talk to e.g. Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and remove the \
> .protocol files, or? 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing (at least \
> if I read KProtocolInfo docs the right way). Can do the same trick as desktop2json \
> does for that. Seems not that hard. But then we need CMake stuff for it, or? To \
> convert on the fly to have translations using the .protocol files like we have ATM \
> in the .desktop files for the plugin stuff. 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is support for \
> translating json files directly in l10n (json -> po -> json) these days. As I said, \
> please ask Luigi or maybe Albert. 
> Christoph Cullmann wrote:
> Ok ;=)
> 
> Christoph Cullmann wrote:
> CC Luigi here, too.
> I looked again at what we have btw. in the other frameworks and I nowhere really \
> found any json -> po and back way, but that doesn't mean its not there ;=) 
> David Faure wrote:
> I'm pretty sure this is all done in the l10n module, not in the other frameworks.
> 
> Christoph Cullmann wrote:
> Any idea who else to ping? With that patch at least the shipped IO slaves work \
> perfect on Win/Lin without any hacks, I would really like to get that in. Some \
> .protocol -> json -> ... translation stuff should be easy to do, but for \
> translating the list inside JSON I am a bit lost ;=) 
> Luigi Toscano wrote:
> Generically, the i18n (or l10n, never rememeber) group. This specific code \
> (translation of json) was done by Burkhard Lueck. Now, I was out for vacation and \
> business, so give some time. It's too late anyway from the next framework version, \
> so there is one month. 
> Christoph Cullmann wrote:
> Hi,
> 
> can I commit my changes to the converted + the i18n aware reading?
> 
> Will do a new review request for the actual conversion of the remaining .protocol \
> files afterwards.

Hi, I updated the request to only incooperate the handling of translations.
Is it ok to commit this now? The change to the kio lib itself is minimal, only the \
protocoltojson got larger changes. For the actual code to do the json translation \
there is the extra request of Alex: https://svn.reviewboard.kde.org/r/7154/

- Christoph

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
-----------------------------------------------------------

On Jan. 3, 2016, 6:19 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2016, 6:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, \
> and Luigi Toscano. 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Allows protocoltojson & kio to handle translated json ExtraNames
> 
> 
> Diffs
> -----
> 
> src/core/kprotocolinfo.cpp 7bfb9ad 
> src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> -------
> 
> make && make test still OK.
> 
> 
> File Attachments
> ----------------
> 
> trash.json
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
>  
> 
> Thanks,
> 
> Christoph Cullmann
> 
> 

--===============1203382998458185381==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125869/">https://git.reviewboard.kde.org/r/125869/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 30th, 2015, 7:29 a.m. UTC, <b>David \
Faure</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/125869/diff/1/?file=413338#file413338line6" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ioslaves/trash/trash.json</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">6</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="s2">&quot;Ursprünglicher Pfad&quot;</span><span \
class="p">,</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
doesn't look very English to me ;)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The original is:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ExtraNames=Original Path,Deletion Date</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
this shows a problem: missing support for translating this field. We didn't realize \
there was a translatable field in these files. Please add support for translations, \
like was done for other json files (talk to e.g. Luigi Toscano).</p></pre>  \
</blockquote>

 <p>On October 30th, 2015, 7:43 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, \
then we have a problem: We can no longer convert the stuff and remove the .protocol \
files, or?</p></pre>  </blockquote>

 <p>On October 30th, 2015, 8:23 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
did read up a bit, ExtraNames seems to be the only translated thing (at least if I \
read KProtocolInfo docs the right way). Can do the same trick as desktop2json does \
for that. Seems not that hard. But then we need CMake stuff for it, or? To convert on \
the fly to have translations using the .protocol files like we have ATM in the \
.desktop files for the plugin stuff.</p></pre>  </blockquote>

 <p>On October 30th, 2015, 8:36 a.m. UTC, <b>David Faure</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think you're looking in the right direction. AFAIK there is support for \
translating json files directly in l10n (json -&gt; po -&gt; json) these days. As I \
said, please ask Luigi or maybe Albert.</p></pre>  </blockquote>

 <p>On October 30th, 2015, 8:38 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok \
;=)</p></pre>  </blockquote>

 <p>On November 1st, 2015, 6:12 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CC \
Luigi here, too. I looked again at what we have btw. in the other frameworks and I \
nowhere really found any json -&gt; po and back way, but that doesn't mean its not \
there ;=)</p></pre>  </blockquote>

 <p>On November 2nd, 2015, 7:25 a.m. UTC, <b>David Faure</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
pretty sure this is all done in the l10n module, not in the other \
frameworks.</p></pre>  </blockquote>

 <p>On November 3rd, 2015, 2:56 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any \
idea who else to ping? With that patch at least the shipped IO slaves work perfect on \
Win/Lin without any hacks, I would really like to get that in. Some .protocol -&gt; \
json -&gt; ... translation stuff should be easy to do, but for translating the list \
inside JSON I am a bit lost ;=)</p></pre>  </blockquote>

 <p>On November 3rd, 2015, 3:12 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Generically, the i18n (or l10n, never rememeber) group. This specific code \
(translation of json) was done by Burkhard Lueck. Now, I was out for vacation and \
business, so give some time. It's too late anyway from the next framework version, so \
there is one month.</p></pre>  </blockquote>

 <p>On January 1st, 2016, 7:26 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hi,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">can I commit my changes to the converted + the i18n \
aware reading?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Will do a new review request for the \
actual conversion of the remaining .protocol files afterwards.</p></pre>  \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hi, I updated the request to only incooperate the handling of translations. \
Is it ok to commit this now? The change to the kio lib itself is minimal, only the \
protocoltojson got larger changes. For the actual code to do the json translation \
there is the extra request of Alex: https://svn.reviewboard.kde.org/r/7154/</p></pre> \
<br />

<p>- Christoph</p>

<br />
<p>On January 3rd, 2016, 6:19 p.m. UTC, Christoph Cullmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David \
Faure, and Luigi Toscano.</div> <div>By Christoph Cullmann.</div>

<p style="color: grey;"><i>Updated Jan. 3, 2016, 6:19 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allows protocoltojson &amp; kio to handle translated \
json ExtraNames</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make &amp;&amp; make test still OK.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kprotocolinfo.cpp <span style="color: grey">(7bfb9ad)</span></li>

 <li>src/protocoltojson/main.cpp <span style="color: grey">(05b9364)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125869/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json">trash.json</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1203382998458185381==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 