From kde-frameworks-devel Sun Jan 10 19:04:16 2016 From: "David Faure" Date: Sun, 10 Jan 2016 19:04:16 +0000 To: kde-frameworks-devel Subject: Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json() Message-Id: <20160110190416.23702.86477 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=145245267618630 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7855884627079038597==" --===============7855884627079038597== Content-Type: multipart/alternative; boundary="===============4733066596251671150==" --===============4733066596251671150== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/#review90842 ----------------------------------------------------------- src/ioslaves/http/kcookiejar/kcookiejar.json (line 96) Why was this set to false (and autoload to true) when the kcookiejar.desktop file had X-KDE-Kded-autoload=false X-KDE-Kded-load-on-demand=true ? I assume it wasn't intentional, but a copy/paste error? - David Faure On Sept. 8, 2015, 7:28 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125048/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 7:28 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Use JSON files directly instead of kcoreaddons_desktop_to_json() > > > Diffs > ----- > > src/ioslaves/http/kcookiejar/CMakeLists.txt 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 > src/ioslaves/http/kcookiejar/kcookiejar.desktop 3ea56abdc134cae22b69d7b7636ce6dd415a3d9b > src/ioslaves/http/kcookiejar/kcookiejar.json PRE-CREATION > src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc > src/kpac/proxyscout.desktop a545f3d6ef2fd18b1a2c85ebff15c9f2513d87f1 > src/kpac/proxyscout.json PRE-CREATION > src/kpasswdserver/CMakeLists.txt 11c30201012fbe413ff58561b54255e88c2c55b9 > src/kpasswdserver/kpasswdserver.desktop bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9 > src/kpasswdserver/kpasswdserver.json PRE-CREATION > src/kssld/CMakeLists.txt bf6970c2741a6edd01e36b86744d643e70046889 > src/kssld/kssld.desktop 86581b208ffc89fa5235f9284395d9d7ccebc472 > src/kssld/kssld.json PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125048/diff/ > > > Testing > ------- > > > Thanks, > > Alex Richardson > > --===============4733066596251671150== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/

src/ioslaves/http/kcookiejar/kcookiejar.json (Diff revision 1)
		96	"X-KDE-Kded-load-on-demand": false

Why was this set to false (and autoload to true) when the kcookiejar.desktop file had X-KDE-Kded-autoload=false X-KDE-Kded-load-on-demand=true ?

I assume it wasn't intentional, but a copy/paste error?

- David Faure

On September 8th, 2015, 7:28 p.m. UTC, Alex Richardson wrote:

Review request for KDE Frameworks and David Faure.

By Alex Richardson.

Updated Sept. 8, 2015, 7:28 p.m.

Repository: kio

Description

Use JSON files directly instead of kcoreaddons_desktop_to_json()

Diffs

src/ioslaves/http/kcookiejar/CMakeLists.txt (7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365)
src/ioslaves/http/kcookiejar/kcookiejar.desktop (3ea56abdc134cae22b69d7b7636ce6dd415a3d9b)
src/ioslaves/http/kcookiejar/kcookiejar.json (PRE-CREATION)
src/kpac/CMakeLists.txt (fc5989714480ca49b5bd72e1c7b458b26bd0d9bc)
src/kpac/proxyscout.desktop (a545f3d6ef2fd18b1a2c85ebff15c9f2513d87f1)
src/kpac/proxyscout.json (PRE-CREATION)
src/kpasswdserver/CMakeLists.txt (11c30201012fbe413ff58561b54255e88c2c55b9)
src/kpasswdserver/kpasswdserver.desktop (bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9)
src/kpasswdserver/kpasswdserver.json (PRE-CREATION)
src/kssld/CMakeLists.txt (bf6970c2741a6edd01e36b86744d643e70046889)
src/kssld/kssld.desktop (86581b208ffc89fa5235f9284395d9d7ccebc472)
src/kssld/kssld.json (PRE-CREATION)

--===============4733066596251671150==-- --===============7855884627079038597== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============7855884627079038597==--