From kde-frameworks-devel Sun Jan 10 16:23:54 2016 From: "David Faure" Date: Sun, 10 Jan 2016 16:23:54 +0000 To: kde-frameworks-devel Subject: Re: Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=. Message-Id: <20160110162354.23702.69946 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=145244306216717 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1704854109834755531==" --===============1704854109834755531== Content-Type: multipart/alternative; boundary="===============2693073405878164432==" --===============2693073405878164432== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/ ----------------------------------------------------------- (Updated Jan. 10, 2016, 4:23 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Changes ------- Submitted with commit 158f62a6710a8ec02eeb9c4e94ee1badd591ae47 by David Faure to branch master. Repository: kio Description ------- QList calls both, so both are needed, but indeed operator= means the members can't be const. Let's just remove the const for the members rather than use const_cast. Change-Id: I9e749a448dc69439ba34ceed31fd7f0032f68c3b Diffs ----- src/core/ksslcertificatemanager_p.h 0b9a85d6f05b93dbe8e80962401dff5ca73617f8 Diff: https://git.reviewboard.kde.org/r/126695/diff/ Testing ------- It compiles. Thanks, David Faure --===============2693073405878164432== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/

This change has been marked as submitted.

Review request for KDE Frameworks.

By David Faure.

Updated Jan. 10, 2016, 4:23 p.m.

Changes

Submitted with commit 158f62a6710a8ec02eeb9c4e94ee1badd591ae47 by David Faure to branch master.

Repository: kio

Description

QList calls both, so both are needed, but indeed operator= means the
members can't be const. Let's just remove the const for the members
rather than use const_cast.

Change-Id: I9e749a448dc69439ba34ceed31fd7f0032f68c3b

Testing

It compiles.

Diffs

src/core/ksslcertificatemanager_p.h (0b9a85d6f05b93dbe8e80962401dff5ca73617f8)

View Diff

--===============2693073405878164432==-- --===============1704854109834755531== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============1704854109834755531==--