'Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver
From:       "David Faure" <faure () kde ! org>
Date:       2016-01-10 10:20:56
Message-ID: 20160110102056.23702.51296 () mimi ! kde ! org
[Download RAW message or body]

--===============6418225210295538921==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126692/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kio

Description
-------

This way the calling code can just ask for that service name
rather than having to know if it's in kded, kiod, or a separate process.

For kpasswdserver it's not a problem since the only calling code is
in kio as well, but I'm generalizing this solution for all kiod modules.

I can't remember why I didn't do this at the time of the kpasswdserver port to kiod.

Diffs
-----

  src/kpasswdserver/org.kde.kpasswdserver.service.in PRE-CREATION 
  src/kpasswdserver/CMakeLists.txt 2944e02ca27becb602e651921977f677206bf5c2 
  src/core/kpasswdserverclient.cpp 15738c569b19d86bac98e78c7bf9f3f3112a55a9 

Diff: https://git.reviewboard.kde.org/r/126692/diff/

Testing
-------

`qdbus org.kde.kpasswdserver /modules/kpasswdserver` works even if kiod isn't running \
yet.

Thanks,

David Faure

--===============6418225210295538921==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126692/">https://git.reviewboard.kde.org/r/126692/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This way the calling code can just ask for that \
service name rather than having to know if it's in kded, kiod, or a separate \
process.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For kpasswdserver it's not a problem since the only \
calling code is in kio as well, but I'm generalizing this solution for all kiod \
modules.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I can't remember why I didn't do this at the time of \
the kpasswdserver port to kiod.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">qdbus \
org.kde.kpasswdserver /modules/kpasswdserver</code> works even if kiod isn't running \
yet.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kpasswdserver/org.kde.kpasswdserver.service.in <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kpasswdserver/CMakeLists.txt <span style="color: \
grey">(2944e02ca27becb602e651921977f677206bf5c2)</span></li>

 <li>src/core/kpasswdserverclient.cpp <span style="color: \
grey">(15738c569b19d86bac98e78c7bf9f3f3112a55a9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126692/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6418225210295538921==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 