'Re: Review Request 126681: Duplicate the file descriptor while opening'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126681: Duplicate the file descriptor while opening
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2016-01-09 16:08:41
Message-ID: 20160109160841.6499.11484 () mimi ! kde ! org
[Download RAW message or body]

--===============4826779392417749749==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Jan. 9, 2016, 1:28 nachm., Kai Uwe Broulik wrote:
> > I think we should do a re-spin of KF 5.18?
> 
> Luigi Toscano wrote:
> I think it was already done: \
> https://mail.kde.org/pipermail/release-team/2016-January/009263.html

ok, I was just wondering because it wasn't mentioned in the changelog :)

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126681/#review90814
-----------------------------------------------------------

On Jan. 8, 2016, 9:41 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126681/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 9:41 nachm.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Closing the fd results in kwallet being in a blocked state
> with all requests to it being timed out.
> 
> This fixes the issue.
> 
> Thanks to Christoph Cullmann spotting the issue.
> 
> 
> Diffs
> -----
> 
> src/runtime/kwalletd/main.cpp a48de08 
> 
> Diff: https://git.reviewboard.kde.org/r/126681/diff/
> 
> 
> Testing
> -------
> 
> KWallet no longer times out after login.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
> 

--===============4826779392417749749==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126681/">https://git.reviewboard.kde.org/r/126681/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Januar 9th, 2016, 1:28 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think we should do a re-spin of KF 5.18?</p></pre>  \
</blockquote>

 <p>On Januar 9th, 2016, 2:23 nachm. UTC, <b>Luigi Toscano</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it was already done: \
https://mail.kde.org/pipermail/release-team/2016-January/009263.html</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok, I \
was just wondering because it wasn't mentioned in the changelog :)</p></pre> <br />

<p>- Kai Uwe</p>

<br />
<p>On Januar 8th, 2016, 9:41 nachm. UTC, Martin Klapetek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Jan. 8, 2016, 9:41 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Closing the fd results in kwallet being in a blocked \
state with all requests to it being timed out.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes the issue.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks to Christoph Cullmann spotting the issue.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KWallet no longer times out after login.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/runtime/kwalletd/main.cpp <span style="color: grey">(a48de08)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126681/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4826779392417749749==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 