'Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2016-01-04 16:04:22
Message-ID: 20160104160422.6499.7859 () mimi ! kde ! org
[Download RAW message or body]

--===============1735224682218376888==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126304/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 4:04 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Qt KDE and Yichao Yu.

Changes
-------

Submitted with commit 38d973cced1b2ca8a8c799ebb1bbb9408f191114 by René J.V. Bertin \
to branch master.

Repository: qtcurve

Description
-------

As the title says, this restores the definition of QTC_QT5_ENABLE_KDE in the CMake \
file when a KF5 build is done, and introduces the changes required for that build to \
succeed.

Except for removing references to the m_componentData member (already removed from \
the class; deprecated type) I have not made any other changes to the code.

Diffs
-----

  qt5/CMakeLists.txt 837d9c2 
  qt5/style/CMakeLists.txt 7f65f8c 
  qt5/style/qtcurve.cpp febcfcf 
  qt5/style/qtcurve_api.cpp 87a927f 
  qt5/style/qtcurve_p.h bfc7502 
  qt5/style/qtcurve_primitive.cpp b5a3204 

Diff: https://git.reviewboard.kde.org/r/126304/diff/

Testing
-------

On KUbuntu 14.04 and Mac OS X 10.9.5, both with Qt 5.5.1 and KF5 Frameworks 5.16.0 \
installed under /opt/local

Thanks,

René J.V. Bertin

--===============1735224682218376888==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126304/">https://git.reviewboard.kde.org/r/126304/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Qt KDE and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated Jan. 4, 2016, 4:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 38d973cced1b2ca8a8c799ebb1bbb9408f191114 by René \
J.V. Bertin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As the title says, this restores the definition of \
QTC_QT5_ENABLE_KDE in the CMake file when a KF5 build is done, and introduces the \
changes required for that build to succeed.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Except for removing \
references to the m_componentData member (already removed from the class; deprecated \
type) I have not made any other changes to the code.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On KUbuntu 14.04 and Mac OS X 10.9.5, both with Qt \
5.5.1 and KF5 Frameworks 5.16.0 installed under /opt/local</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>qt5/CMakeLists.txt <span style="color: grey">(837d9c2)</span></li>

 <li>qt5/style/CMakeLists.txt <span style="color: grey">(7f65f8c)</span></li>

 <li>qt5/style/qtcurve.cpp <span style="color: grey">(febcfcf)</span></li>

 <li>qt5/style/qtcurve_api.cpp <span style="color: grey">(87a927f)</span></li>

 <li>qt5/style/qtcurve_p.h <span style="color: grey">(bfc7502)</span></li>

 <li>qt5/style/qtcurve_primitive.cpp <span style="color: grey">(b5a3204)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126304/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1735224682218376888==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 