[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126505: Do not show a warning color before the user even started typing
From: "David Faure" <faure () kde ! org>
Date: 2016-01-04 14:19:33
Message-ID: 20160104141933.6499.31447 () mimi ! kde ! org
[Download RAW message or body]
--===============7296672494213161574==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 2, 2016, 11:33 a.m., David Faure wrote:
> > Ship It!
>
> Elvis Angelaccio wrote:
> Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's because I \
> have kwidgetsaddons 5.17 globally installed from archlinux repos (indeed, the \
> warning color in my local tests is set as soon as something is typed as password, \
> which is the old behavior). Could someone who has kwidgetsaddons installed from \
> git, verify that these new tests pass? (and if they do, feel free to even commit on \
> my behalf).
> David Faure wrote:
> You're committing changes to kwidgetaddons, how can it be that you're not compiling \
> and testing it?
> You should be able to run the test without installing kwidgetaddons, just by \
> setting LD_LIBRARY_PATH to point to the dir where the uninstalled lib is.
> I thought the RPATH handling made this automatic, even... at least it works here:
>
> $ objdump -p ./knewpasswordwidgettest | grep PATH
> RUNPATH \
> /d/qt/5/kde/qtbase/lib:/d/kde/build/5/frameworks/kwidgetsaddons/src
> $ unset LD_LIBRARY_PATH # because here it points to the install dir, but if you use \
> distro packages I guess you didn't set it anyway $ ldd ./knewpasswordwidgettest | \
> grep -i widgetsaddons libKF5WidgetsAddons.so.5 => \
> /d/kde/build/5/frameworks/kwidgetsaddons/src/libKF5WidgetsAddons.so.5 \
> (0x00007f3f73a92000)
> Elvis Angelaccio wrote:
> > $ unset LD_LIBRARY_PATH
>
> This did the trick! It turns out I actually had LD_LIBRARY_PATH defined:
>
> $ echo $LD_LIBRARY_PATH
> /home/elvis/GNUstep/Library/Libraries:/usr/lib
>
> That's why the tests were using the installed library. Thanks David :)
Yep, there's no good reason to ever have /usr/lib in your LD_LIBRARY_PATH. It will be \
found anyway since it's the system fallback, but if you set it explicitly then RPATH \
can never work.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126505/#review90441
-----------------------------------------------------------
On Dec. 27, 2015, 2:40 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126505/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 2:40 p.m.)
>
>
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Faure.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> As discussed in RR 125619 and 126426, the password verification field (in a \
> KNewPasswordWidget) should not be marked as "wrong" before the user even started \
> typing the verification password.
> The revised approach is the following:
>
> * The user starts typing something as password, e.g. 1234
> * The user types something else as verification password
> * As soon as the verification is not anymore a prefix of the password (e.g. \
> verification = 122), the warning color is shown.
> * As soon as the verification is a prefix again (e.g. the user deletes the second \
> 2, i.e. verification = 12) the warning color is not shown anymore.
>
> Diffs
> -----
>
> autotests/knewpasswordwidgettest.h 43845128adec01aced4353c9f7986b7977829a2a
> autotests/knewpasswordwidgettest.cpp 297b88d5f18b9cd37f0d26d94e56f38870756f20
> src/knewpasswordwidget.cpp a1b59454a2c2d7c09ac32acec52d3fffa73f77fc
>
> Diff: https://git.reviewboard.kde.org/r/126505/diff/
>
>
> Testing
> -------
>
> Autotests assert what described above. Gif pictures would explain the patch better \
> than 1000 words, but I suck at creating them :(
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============7296672494213161574==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126505/">https://git.reviewboard.kde.org/r/126505/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 2nd, 2016, 11:33 a.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On January 4th, 2016, 11:51 a.m. UTC, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Uhmm, \
the new tests don't pass locally on my system. I'm fairly sure it's because I have \
kwidgetsaddons 5.17 globally installed from archlinux repos (indeed, the warning \
color in my local tests is set as soon as something is typed as password, which is \
the old behavior). Could someone who has kwidgetsaddons installed from git, verify \
that these new tests pass? (and if they do, feel free to even commit on my \
behalf).</p></pre> </blockquote>
<p>On January 4th, 2016, 1:22 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're committing \
changes to kwidgetaddons, how can it be that you're not compiling and testing it?
You should be able to run the test without installing kwidgetaddons, just by setting \
LD_LIBRARY_PATH to point to the dir where the uninstalled lib is.
I thought the RPATH handling made this automatic, even... at least it works here:
$ objdump -p ./knewpasswordwidgettest | grep PATH
RUNPATH \
/d/qt/5/kde/qtbase/lib:/d/kde/build/5/frameworks/kwidgetsaddons/src
$ unset LD_LIBRARY_PATH # because here it points to the install dir, but if you use \
distro packages I guess you didn't set it anyway $ ldd ./knewpasswordwidgettest | \
grep -i widgetsaddons
libKF5WidgetsAddons.so.5 => \
/d/kde/build/5/frameworks/kwidgetsaddons/src/libKF5WidgetsAddons.so.5 \
(0x00007f3f73a92000)</pre> </blockquote>
<p>On January 4th, 2016, 2:14 p.m. UTC, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">$ unset LD_LIBRARY_PATH</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This did the trick! It turns out I actually had \
LD_LIBRARY_PATH defined:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">$ echo $LD_LIBRARY_PATH
/home/elvis/GNUstep/Library/Libraries:/usr/lib</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">That's why the tests were using the installed library. \
Thanks David :)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yep, \
there's no good reason to ever have /usr/lib in your LD_LIBRARY_PATH. It will be \
found anyway since it's the system fallback, but if you set it explicitly then RPATH \
can never work.</p></pre> <br />
<p>- David</p>
<br />
<p>On December 27th, 2015, 2:40 p.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David \
Faure.</div> <div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2015, 2:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed in RR 125619 and 126426, the password \
verification field (in a KNewPasswordWidget) should not be marked as "wrong" before \
the user even started typing the verification password.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
revised approach is the following:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The user starts typing something as password, e.g. 1234</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The user types something else as verification password</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">As soon as the verification is not anymore a prefix of the password (e.g. \
verification = 122), the warning color is shown.</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">As \
soon as the verification is a prefix again (e.g. the user deletes the second 2, i.e. \
verification = 12) the warning color is not shown anymore.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Autotests assert what described above. Gif pictures \
would explain the patch better than 1000 words, but I suck at creating them \
:(</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/knewpasswordwidgettest.h <span style="color: \
grey">(43845128adec01aced4353c9f7986b7977829a2a)</span></li>
<li>autotests/knewpasswordwidgettest.cpp <span style="color: \
grey">(297b88d5f18b9cd37f0d26d94e56f38870756f20)</span></li>
<li>src/knewpasswordwidget.cpp <span style="color: \
grey">(a1b59454a2c2d7c09ac32acec52d3fffa73f77fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126505/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7296672494213161574==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic