'Re: Review Request 126472: Don't always load the timetracker'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126472: Don't always load the timetracker
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2016-01-04 13:35:55
Message-ID: 20160104133555.6499.9786 () mimi ! kde ! org
[Download RAW message or body]

--===============7896841629796635411==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Dec. 22, 2015, 2:36 p.m., Sebastian Kügler wrote:
> > Nice.
> > 
> > I agree with Aleix that the env var would be good to have documented. (Is that \
> > even English?) But then, where?
> 
> Martin Gräßlin wrote:
> as an idea check: https://community.kde.org/KWin/Environment_Variables

ok, done. https://community.kde.org/Plasma/Environment_Variables

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/#review89924
-----------------------------------------------------------

On Dec. 27, 2015, 7:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126472/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 7:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Don't always load the timetracker
> 
> It has a timer that wakes up every 2 seconds and drains my battery just
> simply because I have debug builds. This make it on demand.
> 
> Don't track containments twice.
> Containments inherit from Applets which also have the same line
> 
> 
> Diffs
> -----
> 
> src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
> src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
> src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 
> 
> Diff: https://git.reviewboard.kde.org/r/126472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============7896841629796635411==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126472/">https://git.reviewboard.kde.org/r/126472/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 22nd, 2015, 2:36 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I agree with Aleix that the env var would be good to have documented. (Is \
that even English?) But then, where?</p></pre>  </blockquote>

 <p>On January 4th, 2016, 7:35 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as an \
idea check: https://community.kde.org/KWin/Environment_Variables</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok, \
done. https://community.kde.org/Plasma/Environment_Variables</p></pre> <br />

<p>- David</p>

<br />
<p>On December 27th, 2015, 7:38 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2015, 7:38 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't always load the timetracker</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It has a timer that wakes up every 2 seconds and drains my battery just \
simply because I have debug builds. This make it on demand.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't \
track containments twice. Containments inherit from Applets which also have the same \
line</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/corona.cpp <span style="color: \
grey">(316b225ecafcfa6e0b8b894cfea082046c296238)</span></li>

 <li>src/plasma/private/applet_p.cpp <span style="color: \
grey">(511b45119f6d91605f36c8b7073a0b0bb4560e5f)</span></li>

 <li>src/plasma/private/containment_p.cpp <span style="color: \
grey">(86d27c43f36b9e1741ab13f8153080fb6b92b321)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126472/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7896841629796635411==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 