'Re: Review Request 126463: Allow applets to set full ToolTip item'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126463: Allow applets to set full ToolTip item
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2016-01-04 9:37:08
Message-ID: 20160104093708.16540.58750 () mimi ! kde ! org
[Download RAW message or body]

--===============8505222957498304264==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review90530
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On Dec. 31, 2015, 6:47 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2015, 6:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -----
> 
> src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
> src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> -------
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
> 

--===============8505222957498304264==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126463/">https://git.reviewboard.kde.org/r/126463/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On December 31st, 2015, 6:47 p.m. UTC, Martin Klapetek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2015, 6:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adds new property available as Plasmoid.toolTipItem \
that allows to set a full custom item as the tooltip.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The main motivation is to have a custom Item tooltip \
for digital clock to properly format the list of timezones (version of
https://git.reviewboard.kde.org/r/124047/). Adding a custom
PlasmaCore.ToolTipArea to the compact representation does not
work well because then it's a ToolTipArea nested inside another
ToolTipArea (from CompactApplet.qml), this causes a sliding effect
as it changes visual parents when hovering.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I dunno if this could perhaps be fixed, but seems \
redundant to have two ToolTipAreas anyway, so instead this exposes the main applet's
ToolTipArea's mainItem property through Plasmoid.toolTipItem which
the appelts can use to set a custom item.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This has a part2 patch which goes of plasma-desktop: \
https://git.reviewboard.kde.org/r/126464/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I can have custom tooltip item in digital clock \
without any artifacts while all other applets still have correct tooltips.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/scriptengines/qml/plasmoid/appletinterface.h <span style="color: \
grey">(40016b1)</span></li>

 <li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(60b7fa5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126463/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8505222957498304264==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 