[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2016-01-04 7:46:14
Message-ID: 20160104074614.6499.67024 () mimi ! kde ! org
[Download RAW message or body]
--===============0568432368183505180==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 2, 2016, 10:59 a.m., David Edmundson wrote:
> > src/properties.h, line 215
> > <https://git.reviewboard.kde.org/r/126595/diff/2/?file=428207#file428207line215>
> >
> > adding an enum value in the middle breaks API
>
> Kai Uwe Broulik wrote:
> where can I place it? the last entry of course must stay last.
I'd say you can add it before PropertyCount. That will change the value of \
PropertyCount, but that's kind of expected. It will break API, but it shouldn't \
affect in real world situations.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126595/#review90435
-----------------------------------------------------------
On Jan. 2, 2016, 2:32 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126595/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 2:32 a.m.)
>
>
> Review request for KDE Frameworks and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> This attribute is set, for example by Chrome and newer versions of wget, and \
> indicates the original URL this file was downloaded from.
> https://wiki.freedesktop.org/www/CommonExtendedAttributes/
>
>
> Diffs
> -----
>
> src/properties.h 64ba0be
> src/propertyinfo.cpp 0b298b6
> src/usermetadata.h ab58e16
> src/usermetadata.cpp 51c87f8
>
> Diff: https://git.reviewboard.kde.org/r/126595/diff/
>
>
> Testing
> -------
>
> Works.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0568432368183505180==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126595/">https://git.reviewboard.kde.org/r/126595/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 2nd, 2016, 10:59 a.m. CET, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126595/diff/2/?file=428207#file428207line215" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/properties.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">enum \
Property {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">215</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">OriginUrl</span><span class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">adding an enum value in the middle breaks API</p></pre> </blockquote>
<p>On January 2nd, 2016, 1:26 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">where \
can I place it? the last entry of course must stay last.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'd say you can add it before PropertyCount. That will change the value of \
PropertyCount, but that's kind of expected. It will break API, but it shouldn't \
affect in real world situations.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On January 2nd, 2016, 2:32 a.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2016, 2:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This attribute is set, for example by Chrome and newer \
versions of wget, and indicates the original URL this file was downloaded from.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">https://wiki.freedesktop.org/www/CommonExtendedAttributes/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/properties.h <span style="color: grey">(64ba0be)</span></li>
<li>src/propertyinfo.cpp <span style="color: grey">(0b298b6)</span></li>
<li>src/usermetadata.h <span style="color: grey">(ab58e16)</span></li>
<li>src/usermetadata.cpp <span style="color: grey">(51c87f8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126595/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0568432368183505180==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic