[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.
From: "Ralf Habacker" <ralf.habacker () freenet ! de>
Date: 2016-01-03 17:30:28
Message-ID: 20160103173028.6499.62001 () mimi ! kde ! org
[Download RAW message or body]
--===============3642489114697825940==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 3, 2016, 4:22 nachm., Alex Richardson wrote:
> > According to the documentation AppLocalDataLocation is the following: \
> > "C:/Users/<USER>/AppData/Local/<APPNAME>", "C:/ProgramData/<APPNAME>", \
> > "<APPDIR>", "<APPDIR>/data"
> > In which directory are the desktop files? Unfortunately I can't check as my \
> > Windows machine broke a while back and I haven't compiled KF5 on Windows since.
> > Patch looks good to me otherwise as it will still check the same directories \
> > change behaviour on Linux. Only minor issue is that the error message is a little \
> > bit confusing now.
>
> Christoph Cullmann wrote:
> hi, same problem occurs on mac, too, i think a better fallback would be something \
> install prefix relative, that would work on win + mac.
> Alex Richardson wrote:
> Would checking `${KDE_INSTALL_FULL_KSERVICETYPES5DIR} + path` first and then fall \
> back to GenericDataLocation work on Windows and Mac? Or do we still need the \
> AppDataLocation for runtime detection of the paths?
From https://build.opensuse.org/build/home:rhabacker:branches:windows:mingw:win32:KF516/openSUSE_13.2/x86_64/mingw32-umbrello5/_log
...
Installing: /home/abuild/rpmbuild/BUILDROOT/mingw32-umbrello5-2.18.99.6f6891a-2.25.x86 \
_64/usr/i686-w64-mingw32/sys-root/mingw/share/applications/org.kde.umbrello.desktop
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126618/#review90496
-----------------------------------------------------------
On Jan. 3, 2016, 2:22 nachm., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126618/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 2:22 nachm.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Without this patch kcoreaddons_desktop_to_json() will not find the destop file.
>
> On windows GenericDataLocation returns "C:/Users/<USER>/AppData/Local" or \
> "C:/ProgramData". That is not a path that contains any destip files ;)
> This patch adds AppLocalDataLocation to the seach if the previous search does not \
> return a match.
> Another option would be to hardcode the absolute path to all places that uses \
> kcoreaddons_desktop_to_json(), but that does not feel too nice...
> What other options do we have?
>
>
> Diffs
> -----
>
> src/lib/plugin/desktopfileparser.cpp 1122af8
>
> Diff: https://git.reviewboard.kde.org/r/126618/diff/
>
>
> Testing
> -------
>
> KTextEditor compiles again on windows
>
>
> Thanks,
>
> Kåre Särs
>
>
--===============3642489114697825940==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126618/">https://git.reviewboard.kde.org/r/126618/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Januar 3rd, 2016, 4:22 nachm. CET, <b>Alex \
Richardson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to the documentation AppLocalDataLocation is \
the following: "C:/Users/<USER>/AppData/Local/<APPNAME>", \
"C:/ProgramData/<APPNAME>", "<APPDIR>", "<APPDIR>/data"</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In which directory are the desktop files? Unfortunately I can't check as my \
Windows machine broke a while back and I haven't compiled KF5 on Windows since.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Patch looks good to me otherwise as it will still \
check the same directories change behaviour on Linux. Only minor issue is that the \
error message is a little bit confusing now.</p></pre> </blockquote>
<p>On Januar 3rd, 2016, 4:30 nachm. CET, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hi, \
same problem occurs on mac, too, i think a better fallback would be something install \
prefix relative, that would work on win + mac.</p></pre> </blockquote>
<p>On Januar 3rd, 2016, 5:18 nachm. CET, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would \
checking <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">${KDE_INSTALL_FULL_KSERVICETYPES5DIR} + \
path</code> first and then fall back to GenericDataLocation work on Windows and Mac? \
Or do we still need the AppDataLocation for runtime detection of the paths?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From \
https://build.opensuse.org/build/home:rhabacker:branches:windows:mingw:win32:KF516/openSUSE_13.2/x86_64/mingw32-umbrello5/_log
...
Installing: /home/abuild/rpmbuild/BUILDROOT/mingw32-umbrello5-2.18.99.6f6891a-2.25.x86 \
_64/usr/i686-w64-mingw32/sys-root/mingw/share/applications/org.kde.umbrello.desktop</p></pre>
<br />
<p>- Ralf</p>
<br />
<p>On Januar 3rd, 2016, 2:22 nachm. CET, Kåre Särs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2016, 2:22 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Without this patch kcoreaddons_desktop_to_json() will \
not find the destop file.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">On windows GenericDataLocation returns \
"C:/Users/<USER>/AppData/Local" or "C:/ProgramData". That is not a path that \
contains any destip files ;)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch adds AppLocalDataLocation to \
the seach if the previous search does not return a match. </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Another option would be to hardcode the absolute path to all places that \
uses kcoreaddons_desktop_to_json(), but that does not feel too nice...</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What other options do we have?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KTextEditor compiles again on windows</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/plugin/desktopfileparser.cpp <span style="color: \
grey">(1122af8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126618/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3642489114697825940==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic