'Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal
From:       "Sune Vuorela" <kde () pusling ! com>
Date:       2016-01-02 19:31:19
Message-ID: 20160102193119.30660.1913 () mimi ! kde ! org
[Download RAW message or body]

--===============6951804597585597168==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126610/#review90477
-----------------------------------------------------------

Looks much better than my attempt over in https://git.reviewboard.kde.org/r/120139

- Sune Vuorela

On Jan. 2, 2016, 7:24 p.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126610/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2016, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> -------
> 
> When indexes are removed and their widgets deleted, the event filter on each widget \
> is not removed, leading to the "you should not delete widgets manually"-alike \
> warning. 
> Add an helper forgetAbout() function which performs all the actions done per-widget \
> before deleting each, additionally removing also the event filter. 
> 
> Diffs
> -----
> 
> src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 
> src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 
> src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126610/diff/
> 
> 
> Testing
> -------
> 
> A sample application with widgets for items in the model, removing indexes: no more \
> warning at removal time. 
> 
> Thanks,
> 
> Pino Toscano
> 
> 

--===============6951804597585597168==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126610/">https://git.reviewboard.kde.org/r/126610/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
much better than my attempt over in \
https://git.reviewboard.kde.org/r/120139</p></pre>  <br />

<p>- Sune Vuorela</p>

<br />
<p>On January 2nd, 2016, 7:24 p.m. UTC, Pino Toscano wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Pino Toscano.</div>

<p style="color: grey;"><i>Updated Jan. 2, 2016, 7:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemviews
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When indexes are removed and their widgets deleted, \
the event filter on each widget is not removed, leading to the "you should not delete \
widgets manually"-alike warning.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Add an helper \
forgetAbout() function which performs all the actions done per-widget before deleting \
each, additionally removing also the event filter.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A sample application with widgets for items in the \
model, removing indexes: no more warning at removal time.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kwidgetitemdelegate.cpp <span style="color: \
grey">(779dc2a8a57148fb37f1f5a7194bc9656cb305a4)</span></li>

 <li>src/kwidgetitemdelegatepool.cpp <span style="color: \
grey">(e916dddad8be56bb803e241da43d8cbe7a171ec3)</span></li>

 <li>src/kwidgetitemdelegatepool_p.h <span style="color: \
grey">(401fe193b0954d6c7c721503d4657b7f08e9fd2e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126610/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6951804597585597168==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 