[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126426: Add a warning color to kwalletd's password dialogs
From: "David Faure" <faure () kde ! org>
Date: 2016-01-01 17:04:49
Message-ID: 20160101170449.30660.98818 () mimi ! kde ! org
[Download RAW message or body]
--===============4934767275422439287==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126426/#review90400
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Dec. 24, 2015, 5:55 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126426/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2015, 5:55 p.m.)
>
>
> Review request for KDE Frameworks, KDE Usability and Valentin Rusu.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> Set a "background warning color" when password and its verification do not match, \
> in the KNewPasswordDialog run by kwalletd. This adds a new dependency (needed to \
> avoid hardcoding colors), but I think is a nice feature to have. See RR 125619 for \
> a screenshot: https://git.reviewboard.kde.org/r/125619/file/2515/
>
> Diffs
> -----
>
> src/runtime/kwalletd/CMakeLists.txt ba9e7ba508c74fed1d8101496583061245640aa7
> src/runtime/kwalletd/kwalletd.cpp 6da97031e13240a9630cfa7e0dc3cf42575819c4
>
> Diff: https://git.reviewboard.kde.org/r/126426/diff/
>
>
> Testing
> -------
>
> Compiles fine.
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============4934767275422439287==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126426/">https://git.reviewboard.kde.org/r/126426/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On December 24th, 2015, 5:55 p.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Valentin Rusu.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2015, 5:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Set a "background warning color" when password and its \
verification do not match, in the KNewPasswordDialog run by kwalletd. This adds a new \
dependency (needed to avoid hardcoding colors), but I think is a nice feature to \
have. See RR 125619 for a screenshot: \
https://git.reviewboard.kde.org/r/125619/file/2515/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/runtime/kwalletd/CMakeLists.txt <span style="color: \
grey">(ba9e7ba508c74fed1d8101496583061245640aa7)</span></li>
<li>src/runtime/kwalletd/kwalletd.cpp <span style="color: \
grey">(6da97031e13240a9630cfa7e0dc3cf42575819c4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126426/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4934767275422439287==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic