[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.
From: "Alex Richardson" <arichardson.kde () gmail ! com>
Date: 2016-01-01 18:12:48
Message-ID: 20160101181248.30660.45745 () mimi ! kde ! org
[Download RAW message or body]
--===============1946939397047845091==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90411
-----------------------------------------------------------
I added support for translating the ExtraNames key here: \
https://svn.reviewboard.kde.org/r/7154/
- Alex Richardson
On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:25 p.m.)
>
>
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, \
> and Luigi Toscano.
>
> Repository: kio
>
>
> Description
> -------
>
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
>
>
> Diffs
> -----
>
> src/core/kprotocolinfo.cpp 7bfb9ad
> src/protocoltojson/main.cpp 05b9364
>
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
>
>
> Testing
> -------
>
> Tests still work (one needed patching, as the exec line contains now the full \
> path).
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes \
> it works, sometimes not :/ but even without this change.
>
> File Attachments
> ----------------
>
> trash.json
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
>
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============1946939397047845091==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125869/">https://git.reviewboard.kde.org/r/125869/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
added support for translating the ExtraNames key here: \
https://svn.reviewboard.kde.org/r/7154/</p></pre> <br />
<p>- Alex Richardson</p>
<br />
<p>On December 28th, 2015, 7:25 p.m. GMT, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David \
Faure, and Luigi Toscano.</div> <div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 7:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Convert all io slave .protocol data to json and embed \
it. Allows easier deployment of the slaves.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests still work (one needed patching, as the exec \
line contains now the full path).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Correction: Somehow the \
./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not \
:/ but even without this change.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kprotocolinfo.cpp <span style="color: grey">(7bfb9ad)</span></li>
<li>src/protocoltojson/main.cpp <span style="color: grey">(05b9364)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125869/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json">trash.json</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1946939397047845091==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic