[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter
From: "David Faure" <faure () kde ! org>
Date: 2016-01-01 19:14:25
Message-ID: 20160101191425.30660.68704 () mimi ! kde ! org
[Download RAW message or body]
--===============3591189350391929890==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 1, 2016, 5:15 p.m., David Faure wrote:
> > src/urifilters/shorturi/kshorturifilter.cpp, line 58
> > <https://git.reviewboard.kde.org/r/126474/diff/2/?file=426362#file426362line58>
> >
> > "despite" sounds like the api docs say that it's not thread safe. \
> > AFAICS the docs don't say anything either way. I agree that one \
> > shouldn't assume thread-safety unless explicitly documented, but I \
> > think it's just an omission in the doc, the whole point of the \
> > QRegularExpression API is thread safety.
I talked to Giuseppe, he'll update the docu to mention thread safety.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126474/#review90403
-----------------------------------------------------------
On Dec. 28, 2015, 2:20 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126474/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 2:20 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> A static QRegExp was used but it is not thread safe. QRegularExpression
> seems to be.
>
> BUG: 352356
>
>
> Diffs
> -----
>
> src/urifilters/shorturi/kshorturifilter.cpp \
> 6002ec6925c0acdd20a053f98baca46863f69fa6
> Diff: https://git.reviewboard.kde.org/r/126474/diff/
>
>
> Testing
> -------
>
> I ran the autotests which includes urifilter and I've run krunner which \
> uses it extensively.
>
> Thanks,
>
> David Edmundson
>
>
--===============3591189350391929890==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126474/">https://git.reviewboard.kde.org/r/126474/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On January 1st, 2016, 5:15 \
p.m. UTC, <b>David Faure</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid \
#C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid \
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126474/diff/2/?file=426362#file426362line58" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/urifilters/shorturi/kshorturifilter.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: \
center;"> <tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">static QRegExp sEnvVarExp \
(QL1S("\\$[a-zA-Z_][a-zA-Z0-9_]*"));</pre></td> <td \
colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">57</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"><span class="k">static</span> <span class="n">QRegExp</span> <span \
class="nf">sEnvVarExp</span> <span class="p">(</span><span \
class="n">QL1S</span><span class="p">(</span><span \
class="s">"</span><span class="se">\\</span><span \
class="s">$[a-zA-Z_][a-zA-Z0-9_]*"</span><span \
class="p">));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">58</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">//despite current QRegularExpression documentation, \
QRegularExpression::match appears to be thread safe and safe for our static \
usage</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">"despite" sounds like the api \
docs say that it's not thread safe. AFAICS the docs don't say anything \
either way. I agree that one shouldn't assume thread-safety unless \
explicitly documented, but I think it's just an omission in the doc, the \
whole point of the QRegularExpression API is thread safety.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I talked to Giuseppe, he'll \
update the docu to mention thread safety.</p></pre> <br />
<p>- David</p>
<br />
<p>On December 28th, 2015, 2:20 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 2:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">A static QRegExp was used but \
it is not thread safe. QRegularExpression seems to be.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 352356</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I ran the autotests which \
includes urifilter and I've run krunner which uses it \
extensively.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/urifilters/shorturi/kshorturifilter.cpp <span style="color: \
grey">(6002ec6925c0acdd20a053f98baca46863f69fa6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126474/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3591189350391929890==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic