[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana
From: "David Faure" <faure () kde ! org>
Date: 2016-01-01 16:46:42
Message-ID: 20160101164642.30660.10537 () mimi ! kde ! org
[Download RAW message or body]
--===============1080647810609826100==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 1, 2016, 3:04 p.m., David Faure wrote:
> > This is kdelibs4support, this code is doomed to disappear and apps are using \
> > kDebug less and less. Is it worth risking compilation breakages on some systems?
> > Also I found kBacktrace less and less useful over the years because with hidden \
> > visibility I get a lot of "???" for non-exported methods. gdb works much better.
>
> René J.V. Bertin wrote:
> I'd hope that we can avoid the compilation breakages and have no idea of the \
> timescale of planned obsolescence.
> I'm actually still getting pretty useful backtraces in KDE4 applications; I'd have \
> to see how that works out for Qt5 apps (QtCurve uses kdelibs4support; I could use \
> that to get kbacktraces from pretty "deep" places ;) ).
> So how does DrKonqi/KF5 work? Doesn't it use equivalent code if not built on \
> kdelibs4support itself?
My problems where in kde4 apps.
drkonqi attaches a debugger, it does not use a backtrace function.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126309/#review90392
-----------------------------------------------------------
On Dec. 10, 2015, 10:10 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126309/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 10:10 p.m.)
>
>
> Review request for KDE Software on Mac OS X and KDE Frameworks.
>
>
> Repository: kdelibs4support
>
>
> Description
> -------
>
> This is a "backport" of the patches to `kdebug.cpp` that enable backtrace and \
> demangling support on OS X, FreeBSD and Solaris/OpenIndiana. The KDE4 version was \
> discussed here: https://git.reviewboard.kde.org/r/121213/
> It seems that change was never incorporated because of a single open issue for \
> which I never found the time (also given that it seemed a bit overkill).
> My PC-BSD and Indiana VMs are no longer operational; it seems highly likely that \
> the current code still works but if further testing or polishing is required I'll \
> rather remove the specific parts than bring the VMs online again.
>
> Diffs
> -----
>
> src/kdecore/kdebug.cpp 6f04dce
>
> Diff: https://git.reviewboard.kde.org/r/126309/diff/
>
>
> Testing
> -------
>
> On Kubuntu 14.04 with various gcc versions and clang; OS X 10.6 - 10.9 with gcc and \
> clang, PC-BSD with clang and on Open Indiana.
> The KDE4 RR raises some doubts concerning checking for only an OS and not compilers \
> (in demangling). I think there is no reason for such doubts: compilers are obliged \
> to co-exist and be compatible nowadays, at least on individual OS families (each \
> platform will have its own default/dominant compiler that is used to build the \
> system libraries). In practice it turns out that gcc and clang use the same C++ \
> mangling scheme. The only difference is in the way `backtrace_symbols()` formats \
> the stack, and that indeed appears to defined the OS rather than by the compiler \
> used. (Then again I'm willing to stand corrected by someone who has a Linux system \
> built from scratch with clang and libc++, or possibly a Gnu/BSD set-up :))
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============1080647810609826100==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126309/">https://git.reviewboard.kde.org/r/126309/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 1st, 2016, 3:04 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is kdelibs4support, this code is doomed to \
disappear and apps are using kDebug less and less. Is it worth risking compilation \
breakages on some systems?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also I found kBacktrace less and less \
useful over the years because with hidden visibility I get a lot of "???" for \
non-exported methods. gdb works much better.</p></pre> </blockquote>
<p>On January 1st, 2016, 4:43 p.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
hope that we can avoid the compilation breakages and have no idea of the timescale of \
planned obsolescence.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'm actually still getting pretty \
useful backtraces in KDE4 applications; I'd have to see how that works out for Qt5 \
apps (QtCurve uses kdelibs4support; I could use that to get kbacktraces from pretty \
"deep" places ;) ).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">So how does DrKonqi/KF5 work? Doesn't \
it use equivalent code if not built on kdelibs4support itself?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
problems where in kde4 apps.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">drkonqi attaches a debugger, it does \
not use a backtrace function.</p></pre> <br />
<p>- David</p>
<br />
<p>On December 10th, 2015, 10:10 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDE Frameworks.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2015, 10:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a "backport" of the patches to <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">kdebug.cpp</code> that enable backtrace and demangling \
support on OS X, FreeBSD and Solaris/OpenIndiana. The KDE4 version was discussed \
here: https://git.reviewboard.kde.org/r/121213/</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
seems that change was never incorporated because of a single open issue for which I \
never found the time (also given that it seemed a bit overkill).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">My PC-BSD and Indiana VMs are no longer operational; it seems highly likely \
that the current code still works but if further testing or polishing is required \
I'll rather remove the specific parts than bring the VMs online again.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Kubuntu 14.04 with various gcc versions and clang; \
OS X 10.6 - 10.9 with gcc and clang, PC-BSD with clang and on Open Indiana. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The KDE4 RR raises some doubts concerning checking for only an OS and not \
compilers (in demangling). I think there is no reason for such doubts: compilers are \
obliged to co-exist and be compatible nowadays, at least on individual OS families \
(each platform will have its own default/dominant compiler that is used to build the \
system libraries). In practice it turns out that gcc and clang use the same C++ \
mangling scheme. The only difference is in the way <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">backtrace_symbols()</code> formats the stack, and that indeed appears to \
defined the OS rather than by the compiler used. (Then again I'm willing to stand \
corrected by someone who has a Linux system built from scratch with clang and libc++, \
or possibly a Gnu/BSD set-up :))</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdecore/kdebug.cpp <span style="color: grey">(6f04dce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126309/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1080647810609826100==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic