'Re: Review Request 126313: Use an xcb for interaction with KStartupInfo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126313: Use an xcb for interaction with KStartupInfo
From:       "David Faure" <faure () kde ! org>
Date:       2016-01-01 15:06:06
Message-ID: 20160101150606.30660.87280 () mimi ! kde ! org
[Download RAW message or body]

--===============6070783866674417915==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126313/#review90393
-----------------------------------------------------------

Ship it!

Ship It!

- David Faure

On Dec. 11, 2015, 2:08 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126313/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 2:08 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> By changing to xcb we can use NETRootInfo to get the current desktop
> and don't need to duplicate the logic. Also it means that more code
> is ported from XLib to xcb and might allow us to drop the XLib
> dependency in future.
> 
> 
> Diffs
> -----
> 
> src/kdeinit/kinit.cpp a18008a11bf00a35aa0cab450180926217cd58f5 
> src/kdeinit/CMakeLists.txt f94db717f2403b602648286eac243837d8714069 
> src/config-kdeinit.h.cmake cfcfc61a1bb560ff9a902b89bd3b8fb27273ebf2 
> CMakeLists.txt eeecab775cfb5dfe12cf9c4991c658cc261ed727 
> 
> Diff: https://git.reviewboard.kde.org/r/126313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

--===============6070783866674417915==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126313/">https://git.reviewboard.kde.org/r/126313/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- David Faure</p>

<br />
<p>On December 11th, 2015, 2:08 p.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Dec. 11, 2015, 2:08 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">By changing to xcb we can use NETRootInfo to get the current desktop and \
don&#39;t need to duplicate the logic. Also it means that more code is ported from \
XLib to xcb and might allow us to drop the XLib dependency in future.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdeinit/kinit.cpp <span style="color: \
grey">(a18008a11bf00a35aa0cab450180926217cd58f5)</span></li>

 <li>src/kdeinit/CMakeLists.txt <span style="color: \
grey">(f94db717f2403b602648286eac243837d8714069)</span></li>

 <li>src/config-kdeinit.h.cmake <span style="color: \
grey">(cfcfc61a1bb560ff9a902b89bd3b8fb27273ebf2)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(eeecab775cfb5dfe12cf9c4991c658cc261ed727)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126313/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6070783866674417915==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 